You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/07/15 21:13:12 UTC

Review Request 71077: Added a test to ensure that ancestor roles are exposed in /roles.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71077/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Meng Zhu.


Bugs: MESOS-9890
    https://issues.apache.org/jira/browse/MESOS-9890


Repository: mesos


Description
-------

This adds a test for MESOS-9890, to ensure that ancestor roles with
no objects directly associated with them get exposed in /roles.


Diffs
-----

  src/tests/role_tests.cpp 5066e419c68d362dcbb785ac803e9c5c7415032b 


Diff: https://reviews.apache.org/r/71077/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Re: Review Request 71077: Added a test to ensure that ancestor roles are exposed in /roles.

Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71077/#review216625
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On July 15, 2019, 2:13 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71077/
> -----------------------------------------------------------
> 
> (Updated July 15, 2019, 2:13 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-9890
>     https://issues.apache.org/jira/browse/MESOS-9890
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds a test for MESOS-9890, to ensure that ancestor roles with
> no objects directly associated with them get exposed in /roles.
> 
> 
> Diffs
> -----
> 
>   src/tests/role_tests.cpp 5066e419c68d362dcbb785ac803e9c5c7415032b 
> 
> 
> Diff: https://reviews.apache.org/r/71077/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>