[GitHub] [ozone] ayushtkn commented on a change in pull request #2888: HDDS-6067. Improve Debugging around unhealthy container state on Datanode.

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #2888:
URL: https://github.com/apache/ozone/pull/2888#discussion_r762919261



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java
##########
@@ -299,6 +299,9 @@ public void markContainerUnhealthy() throws StorageContainerException {
     } finally {
       writeUnlock();
     }
+    LOG.warn("Moving container {} to state UNHEALTHY from state:{}",
+            containerData.getContainerPath(), containerData.getState(),
+            new Exception());

Review comment:
       Is this ``new Exception()`` for adding the trace? Can we not use  ``StringUtils.getStackTrace(Thread.currentThread())``, else we would have an extra line saying ``java.lang.Exception`` without having any actual exception




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org