You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by dlukyanov <gi...@git.apache.org> on 2017/03/14 20:09:56 UTC
[GitHub] zeppelin pull request #2135: [WIP] Groovy Interpreter for Apazhe Zeppelin [Z...
GitHub user dlukyanov opened a pull request:
https://github.com/apache/zeppelin/pull/2135
[WIP] Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
### What is this PR for?
Groovy Interpreter
### What type of PR is it?
Feature
### Todos
* [ Tests ] - Task
* [ Documentation ] - Task
### What is the Jira issue?
[ZEPPELIN-2176]
### How should this be tested?
Follow the groovy interpreter documentation samples
### Questions:
* Does the licenses files need update? YES
* Is there breaking changes for older versions? NO
* Does this needs documentation? YES
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dlukyanov/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2135
----
commit fa779ea5df077a746ed92c1e8f6e81fd98206560
Author: dlukyanov <dl...@ukr.net>
Date: 2017-03-14T20:00:13Z
groovy interpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: [WIP] Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
Jenkins build script didn't handle well when source branch name of pullrequest is `master`.
I just updated the jenkins build script to handle the name `master`.
@dlukyanov Could you trigger jenkins again (close/open pr) and see if it checks correctly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2135
Looks good to me :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: [WIP] Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN...
Posted by dlukyanov <gi...@git.apache.org>.
Github user dlukyanov commented on the issue:
https://github.com/apache/zeppelin/pull/2135
@Leemoonsoo, I moved the repo under the user, used the latest master, now i have another error:
```
++ grep -e '"ref":' -e '"sha":'
++ tr '\n' ' '
+ COMMIT=
+ sleep 30
+ python ./travis_check.py dlukyanov
Traceback (most recent call last):
File "./travis_check.py", line 36, in <module>
commit = sys.argv[2]
IndexError: list index out of range
Build step 'Execute shell' marked build as failure
Putting comment on the pull request
Finished: FAILURE
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by dlukyanov <gi...@git.apache.org>.
Github user dlukyanov commented on the issue:
https://github.com/apache/zeppelin/pull/2135
@Leemoonsoo , @AhyoungRyu , any other comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by dlukyanov <gi...@git.apache.org>.
Github user dlukyanov commented on the issue:
https://github.com/apache/zeppelin/pull/2135
@Leemoonsoo Interesting) I did not knew that... i'll take a look how it's implemented...
With doc - i'll move it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
Merge to master if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: [WIP] Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN...
Posted by dlukyanov <gi...@git.apache.org>.
Github user dlukyanov commented on the issue:
https://github.com/apache/zeppelin/pull/2135
@Leemoonsoo, now I see status from travis )
And going to solve strange build errors...
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by dlukyanov <gi...@git.apache.org>.
Github user dlukyanov commented on the issue:
https://github.com/apache/zeppelin/pull/2135
@Leemoonsoo, Just committed changes.
Doc moved.
About shared vars - it will be a little different from scala/spark.
If you use groovy script variable (undeclared or annotated) it will behave like you mentioned
```java
a="Hello world"
//or
@groovy.transform.Field String aa = "Hello world"
//or
g.put('aaa',"Hello world")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELI...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
Thanks @dlukyanov for the contribution.
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
I tested last commit and it works well.
However the variable can't be read from the other paragraph.
This behavior is different from other interpreters, like spark (scala), python, r.
Is it intended?
Also, can we place document under `/docs/interpreter/` instead of `/groovy/`, so website can show groovy documentation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: [WIP] Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
The error
```
[ERROR] error An unexpected error occurred: "https://registry.yarnpkg.com/binary-extensions/-/binary-extensions-1.8.0.tgz: Request failed \"502 Bad Gateway\"".
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:yarn (yarn install) on project zeppelin-web: Failed to run task: 'yarn install --no-lockfile' failed. (error code 1) -> [Help 1]
[ERROR]
```
looks like temporary network problem. You can always restart [the failed Job](https://travis-ci.org/dlukyanov/zeppelin/jobs/211224371) and see if it passing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by dlukyanov <gi...@git.apache.org>.
Github user dlukyanov commented on the issue:
https://github.com/apache/zeppelin/pull/2135
@AhyoungRyu, changes committed,waiting for travis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
Looks like second test matrix succeeded after the manual restart.
In this case, you also need to trigger Jenkins again to check latest build status.
Simply close and reopen this PR will do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2135
Thanks for addressing my comments! I left some minor comments again about "author name" in the source code and removing unnecessary `log.info`. Except these two things, LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2135
Merge to master if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: [WIP] Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN...
Posted by dlukyanov <gi...@git.apache.org>.
Github user dlukyanov commented on the issue:
https://github.com/apache/zeppelin/pull/2135
@Leemoonsoo , is it possible to restart jenkins checks after travis succeed?
I've never got travis success without restarting travis jobs manually.
https://travis-ci.org/dlukyanov/zeppelin/builds
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
@dlukyanov Thanks for the update and explanation on behavior.
Inside of docs directory, groovy.md will need some header to be compiled with Jekyll. For example, [spark.md](https://raw.githubusercontent.com/apache/zeppelin/master/docs/interpreter/spark.md)
```
---
layout: page
title: "Apache Spark Interpreter for Apache Zeppelin"
description: "Apache Spark is a fast and general-purpose cluster computing system. It provides high-level APIs in Java, Scala, Python and R, and an optimized engine that supports general execution engine."
group: interpreter
---
<!--
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
{% include JB/setup %}
```
Menu in docs also need link to groovy. https://github.com/apache/zeppelin/blob/master/docs/_includes/themes/zeppelin/_navigation.html#L56
`.travis.yml` is updated since this branch is created. And we need add `!groovy` in [this line](https://github.com/apache/zeppelin/blob/master/.travis.yml#L40). Could you handle it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Posted by dlukyanov <gi...@git.apache.org>.
Github user dlukyanov commented on the issue:
https://github.com/apache/zeppelin/pull/2135
@Leemoonsoo , done. waiting for travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---