You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Starchenko Ilya (Jira)" <ji...@apache.org> on 2023/06/10 14:29:00 UTC

[jira] [Commented] (KAFKA-14218) replace temp file handler with JUnit 5 Temporary Directory Support

    [ https://issues.apache.org/jira/browse/KAFKA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731215#comment-17731215 ] 

Starchenko Ilya commented on KAFKA-14218:
-----------------------------------------

Hello. I noticed no progress on this issue, so I went ahead and took care of it myself. I've created a pull request: https://github.com/apache/kafka/pull/13836. 
Could you please review it when you get a chance? [~showuon] [~divijvaidya] 

> replace temp file handler with JUnit 5 Temporary Directory Support
> ------------------------------------------------------------------
>
>                 Key: KAFKA-14218
>                 URL: https://issues.apache.org/jira/browse/KAFKA-14218
>             Project: Kafka
>          Issue Type: Improvement
>          Components: unit tests
>            Reporter: Luke Chen
>            Assignee: Ganesh Sahu
>            Priority: Major
>              Labels: Newbie, newbie
>
> We created many temp files in tests, and sometimes we forgot to delete them after usage. Instead of polluting @AfterEach for each test, we should consider to use JUnit 5 TempDirectory Extension.
>  
> REF: 1. [https://github.com/apache/kafka/pull/12591#issuecomment-1243001431]
> 2. [https://www.baeldung.com/junit-5-temporary-directory]
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)