You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> on 2008/05/18 14:43:39 UTC
gnome-keyring branch is finished
The 'gnome-keyring' branch is finished.
It adds support for storing passwords in GNOME Keyring.
Support for GNOME Keyring is implemented in the separate library - libsvn_auth_gnome_keyring.
libsvn_auth_gnome_keyring is dynamically loaded by libsvn_subr.
You can use these commands to review this branch:
svn log --stop-on-copy https://svn.collab.net/repos/svn/branches/gnome-keyring
svn di https://svn.collab.net/repos/svn/trunk@31286 https://svn.collab.net/repos/svn/branches/gnome-keyring
--
Arfrever Frehtes Taifersar Arahesis
Re: gnome-keyring branch is finished
Posted by Jeremy Wilkins <je...@ibexinternet.co.uk>.
how about just checking if gnome-session (or kde equivalent) is
running as the current user, then testing for the appropriate
handler. Even if KWallet is available and gnome-keyring is not I
can't imagine a user expecting Kwallet to start handling their
passwords if they're in a Gnome session.
jebw
On 21 May 2008, at 10:01, Branko Čibej wrote:
> Philip Martin wrote:
>> "Mark Phippard" <ma...@gmail.com> writes:
>>
>>
>>> What happens at runtime if both KWallet and GNOME are present and
>>> loadable?
>>>
>>
>> The user should be able to choose which one to use, possibly via a
>> config setting as for neon/serf.
>>
>
> I don't think so. I'd be really, really surprised if you couldn't
> figure out, at runtime, if you're in a KDE or Gnome session.
>
> -- Brane
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: gnome-keyring branch is finished
Posted by Philip Martin <ph...@codematters.co.uk>.
Branko Čibej <br...@xbc.nu> writes:
> Philip Martin wrote:
>> "Mark Phippard" <ma...@gmail.com> writes:
>>
>>
>>> What happens at runtime if both KWallet and GNOME are present and
>>> loadable?
>>>
>>
>> The user should be able to choose which one to use, possibly via a
>> config setting as for neon/serf.
>>
>
> I don't think so. I'd be really, really surprised if you couldn't
> figure out, at runtime, if you're in a KDE or Gnome session.
I don't know how these systems work, do they contact a server process?
Do they automatically start a server process if none is running?
Suppose I normally run a Gnome desktop but occasionally run a KDE
desktop. How do I access my stored passwords? Do I have to logout of
KDE and start Gnome?
Suppose I run neither desktop but a combination of KDE and Gnome
applications. How do I choose which keyring to use?
I don't mind a heuristic that guesses my intention so long as I can
override the heuristic if it gets it wrong.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: gnome-keyring branch is finished
Posted by Branko Čibej <br...@xbc.nu>.
Philip Martin wrote:
> "Mark Phippard" <ma...@gmail.com> writes:
>
>
>> What happens at runtime if both KWallet and GNOME are present and
>> loadable?
>>
>
> The user should be able to choose which one to use, possibly via a
> config setting as for neon/serf.
>
I don't think so. I'd be really, really surprised if you couldn't figure
out, at runtime, if you're in a KDE or Gnome session.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: gnome-keyring branch is finished
Posted by Philip Martin <ph...@codematters.co.uk>.
"Mark Phippard" <ma...@gmail.com> writes:
> What happens at runtime if both KWallet and GNOME are present and
> loadable?
The user should be able to choose which one to use, possibly via a
config setting as for neon/serf.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Tonight's match-up: gnome-keyring vs. kwallet! (was: Re: gnome-keyring branch is finished)
Posted by Ben Collins-Sussman <su...@red-bean.com>.
Is there any programmatic way of determining whether the user happens
to be running KDE or GNOME at run-time? That would result in behavior
that least-surprises users.
On Tue, May 20, 2008 at 4:41 AM, Stefan Sperling <st...@elego.de> wrote:
> On Mon, May 19, 2008 at 02:05:25PM -0400, Mark Phippard wrote:
>> What happens at runtime if both KWallet and GNOME are present and
>> loadable? I'd personally like to see GNOME be given preference as it
>> worked nicer in my testing. I think it currently loads KWallet first,
>> so I assume that means it gets first chance.
>
> Let's just use a good-quality PRNG and let it decide what the default
> should be. For numbers between 0.0 and 0.5 inclusive, gnome-keyring wins,
> for numbers between 0.5 exclusive and 1.0 inclusive, kwallet wins.
>
> Alternatively, two dice, one for kwallet, one for Gnome-Keyring,
> might also do the job. This could possibly require repeated rolling
> -- whichever gets a higher number first, wins. We should probably
> appoint a neutral party for supervising the process.
>
> Matters will be complicated further should we ever grow GPGME
> support in the future. But we can delay that decision until
> further notice. Let's not tax our brains too much unless absolutely
> necessary.
>
> Oh, and we could also have committers vote, of course. But with
> paper ballots, please. Many people (including myself) don't trust
> other ways of voting too much.
>
> :)
>
> Stefan
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Tonight's match-up: gnome-keyring vs. kwallet! (was: Re:
gnome-keyring branch is finished)
Posted by Stefan Sperling <st...@elego.de>.
On Mon, May 19, 2008 at 02:05:25PM -0400, Mark Phippard wrote:
> What happens at runtime if both KWallet and GNOME are present and
> loadable? I'd personally like to see GNOME be given preference as it
> worked nicer in my testing. I think it currently loads KWallet first,
> so I assume that means it gets first chance.
Let's just use a good-quality PRNG and let it decide what the default
should be. For numbers between 0.0 and 0.5 inclusive, gnome-keyring wins,
for numbers between 0.5 exclusive and 1.0 inclusive, kwallet wins.
Alternatively, two dice, one for kwallet, one for Gnome-Keyring,
might also do the job. This could possibly require repeated rolling
-- whichever gets a higher number first, wins. We should probably
appoint a neutral party for supervising the process.
Matters will be complicated further should we ever grow GPGME
support in the future. But we can delay that decision until
further notice. Let's not tax our brains too much unless absolutely
necessary.
Oh, and we could also have committers vote, of course. But with
paper ballots, please. Many people (including myself) don't trust
other ways of voting too much.
:)
Stefan
Re: gnome-keyring branch is finished
Posted by David Glasser <gl...@davidglasser.net>.
On Tue, May 20, 2008 at 9:23 PM, Peter Samuelson <pe...@p12n.org> wrote:
> Unless a single user is running multiple agents ... but why would you
> do that?
Because as we've just found out, they have completely different APIs
and different build system challenges, so it's not difficult to
imagine that the user runs two other apps, one of which integrates
with gnome-keyring and the other of which integrates with KWallet?
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: gnome-keyring branch is finished
Posted by Peter Samuelson <pe...@p12n.org>.
[Dan Christian]
> You probably need to be smarter. Just because you can load the
> interface, doesn't mean that it is use.
Surely the password agent clients can detect whether there is a
corresponding password agent server to talk to? In which case, order
doesn't matter, you try them all until one finds an agent to talk to.
Unless a single user is running multiple agents ... but why would you
do that? And if you do, do you not deserve what you get?
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
Re: gnome-keyring branch is finished
Posted by Dan Christian <dc...@google.com>.
On Mon, May 19, 2008 at 11:05 AM, Mark Phippard <ma...@gmail.com> wrote:
> What happens at runtime if both KWallet and GNOME are present and
> loadable?
I would think this would be the case on many distros.
>I'd personally like to see GNOME be given preference as it
> worked nicer in my testing. I think it currently loads KWallet first,
> so I assume that means it gets first chance.
You probably need to be smarter. Just because you can load the
interface, doesn't mean that it is use.
For example, I use a KDE desktop environment, so I would expect
kwallet to be used. However, the gnome keyring is loadable, yet
empty.
It should either be smart about where there is data (which probably
triggers the user to unlock an empty or un-initialized key safe), or
make it user configurable.
The alternative is to force the distro packages to be only be built
with only the "right" option available. Yuck.
Just when you thought it was finished... :-)
-Dan C
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: gnome-keyring branch is finished
Posted by Mark Phippard <ma...@gmail.com>.
On Sun, May 18, 2008 at 10:43 AM, Arfrever Frehtes Taifersar Arahesis
<ar...@gmail.com> wrote:
> The 'gnome-keyring' branch is finished.
> It adds support for storing passwords in GNOME Keyring.
>
> Support for GNOME Keyring is implemented in the separate library - libsvn_auth_gnome_keyring.
> libsvn_auth_gnome_keyring is dynamically loaded by libsvn_subr.
>
> You can use these commands to review this branch:
> svn log --stop-on-copy https://svn.collab.net/repos/svn/branches/gnome-keyring
> svn di https://svn.collab.net/repos/svn/trunk@31286 https://svn.collab.net/repos/svn/branches/gnome-keyring
With Arfrever's help, I added the JavaHL support to this branch. I
tested both command line and Eclipse and it all works great. I think
it can be merged to trunk.
What happens at runtime if both KWallet and GNOME are present and
loadable? I'd personally like to see GNOME be given preference as it
worked nicer in my testing. I think it currently loads KWallet first,
so I assume that means it gets first chance.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org