You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2022/10/06 08:22:01 UTC

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19099


Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................

IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

This change adds the possibility to set the partition file format
at creation by allowing to use the SET FORMAT clause at the end of
the ALTER TABLE ADD statement. The file format specification will
be applied to all listed partitions, for example:
ALTER TABLE tbl ADD PARTITION (i=1) PARTITION (i=2) SET FILEFORMAT
PARQUET; will create two Parquet-formatted partition metadata
entries.

Tests:
 - analyzer test for the new syntax element
 - e2e test for adding partition in a specified format

Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
6 files changed, 82 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/19099/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 7: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 18:19:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, lipenglin@sensorsdata.cn, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19099

to look at the new patch set (#4).

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................

IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

This change adds the possibility to set the partition file format
at creation by allowing to use the SET FORMAT clause at the end of
the ALTER TABLE ADD statement. The file format specification will
be applied to all listed partitions, for example:
ALTER TABLE tbl ADD PARTITION (i=1) PARTITION (i=2) SET FILEFORMAT
PARQUET; will create two Parquet-formatted partition metadata
entries.

Tests:
 - analyzer test for the new syntax element
 - e2e test for adding partition in a specified format

Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
5 files changed, 44 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/19099/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19099

to look at the new patch set (#2).

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................

IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

This change adds the possibility to set the partition file format
at creation by allowing to use the SET FORMAT clause at the end of
the ALTER TABLE ADD statement. The file format specification will
be applied to all listed partitions, for example:
ALTER TABLE tbl ADD PARTITION (i=1) PARTITION (i=2) SET FILEFORMAT
PARQUET; will create two Parquet-formatted partition metadata
entries.

Tests:
 - analyzer test for the new syntax element
 - e2e test for adding partition in a specified format

Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
6 files changed, 84 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/19099/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19099/4/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/19099/4/tests/metadata/test_ddl.py@656
PS4, Line 656: +
flake8: E226 missing whitespace around arithmetic operator



-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Oct 2022 12:37:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................

IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

This change adds the possibility to set the partition file format
at creation by allowing to use the SET FORMAT clause at the end of
the ALTER TABLE ADD statement. The file format specification will
be applied to all listed partitions, for example:
ALTER TABLE tbl ADD PARTITION (i=1) PARTITION (i=2) SET FILEFORMAT
PARQUET; will create two Parquet-formatted partition metadata
entries.

Tests:
 - analyzer test for the new syntax element
 - e2e test for adding partition in a specified format

Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Reviewed-on: http://gerrit.cloudera.org:8080/19099
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
5 files changed, 63 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 8
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19099

to look at the new patch set (#3).

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................

IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

This change adds the possibility to set the partition file format
at creation by allowing to use the SET FORMAT clause at the end of
the ALTER TABLE ADD statement. The file format specification will
be applied to all listed partitions, for example:
ALTER TABLE tbl ADD PARTITION (i=1) PARTITION (i=2) SET FILEFORMAT
PARQUET; will create two Parquet-formatted partition metadata
entries.

Tests:
 - analyzer test for the new syntax element
 - e2e test for adding partition in a specified format

Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
6 files changed, 101 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/19099/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 3:

(2 comments)

Thanks for implementing this feature! I leave two comments here.

http://gerrit.cloudera.org:8080/#/c/19099/3/common/thrift/JniCatalog.thrift
File common/thrift/JniCatalog.thrift:

http://gerrit.cloudera.org:8080/#/c/19099/3/common/thrift/JniCatalog.thrift@120
PS3, Line 120: ADD_PARTITION_SET_FILE_FORMAT = 22
Just a suggestion, can we consider reusing TAlterTableType.ADD_PARTITION?
Should only be overloaded AlterTableAddPartitionStmt constructor, without creating another class named AlterTableAddPartitionSetFileFormatStmt.


http://gerrit.cloudera.org:8080/#/c/19099/3/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java:

http://gerrit.cloudera.org:8080/#/c/19099/3/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java@66
PS3, Line 66: if (tbl instanceof FeKuduTable) {
            :       throw new AnalysisException(
            :           "ALTER TABLE SET FILEFORMAT is not supported " + "on Kudu tables: "
            :               + tbl.getFullName());
            :     }
            : 
            :     if (tbl instanceof FeIcebergTable) {
            :       throw new AnalysisException(
            :           "ALTER TABLE SET FILEFORMAT is not supported " + "on Iceberg tables: "
            :               + tbl.getFullName());
            :     }
This has been checked at https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java#L85 when 'super.analyze(analyzer);', so this code should be omitted?



-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 09 Oct 2022 09:51:04 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 5: Code-Review+1

LGTM


-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Oct 2022 02:38:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/19099/3/common/thrift/JniCatalog.thrift
File common/thrift/JniCatalog.thrift:

http://gerrit.cloudera.org:8080/#/c/19099/3/common/thrift/JniCatalog.thrift@120
PS3, Line 120: ADD_PARTITION_SET_FILE_FORMAT = 22
> Just a suggestion, can we consider reusing TAlterTableType.ADD_PARTITION?
I agree, if it is possible we should reuse the existing class.


http://gerrit.cloudera.org:8080/#/c/19099/3/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java:

http://gerrit.cloudera.org:8080/#/c/19099/3/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java@66
PS3, Line 66: if (tbl instanceof FeKuduTable) {
            :       throw new AnalysisException(
            :           "ALTER TABLE SET FILEFORMAT is not supported " + "on Kudu tables: "
            :               + tbl.getFullName());
            :     }
            : 
            :     if (tbl instanceof FeIcebergTable) {
            :       throw new AnalysisException(
            :           "ALTER TABLE SET FILEFORMAT is not supported " + "on Iceberg tables: "
            :               + tbl.getFullName());
            :     }
> This has been checked at https://github.com/apache/impala/blob/master/fe/sr
Did you want to throw with a different message than in AlterTableAddPartitionStmt? I think the error message there is okay, we can consider this a case of ALTER TABLE ADD PARTITION.

But if the purpose is to change the error message, we would have to catch the exception from super.analyze() first.


http://gerrit.cloudera.org:8080/#/c/19099/3/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/19099/3/tests/metadata/test_ddl.py@646
PS3, Line 646:     # Add partition with different fileformat
Can we validate that the new partition created really has the specified file type?
As far as I know the default is Parquet, so we should check with another format to see if setting the file format has an effect.



-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Oct 2022 09:01:25 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/19099/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java:

http://gerrit.cloudera.org:8080/#/c/19099/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java@32
PS1, Line 32:     TAlterTableSetFileFormatParams fileFormatParams = new TAlterTableSetFileFormatParams();
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/19099/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/19099/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1057
PS1, Line 1057:           refreshedTable = alterTableAddPartitions(tbl, params.getAdd_partition_params(),format);
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/19099/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/19099/1/tests/metadata/test_ddl.py@648
PS1, Line 648: "
flake8: F523 '...'.format(...) has unused arguments at position(s): 1



-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 08:22:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/11549/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 08:53:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, lipenglin@sensorsdata.cn, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19099

to look at the new patch set (#5).

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................

IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

This change adds the possibility to set the partition file format
at creation by allowing to use the SET FORMAT clause at the end of
the ALTER TABLE ADD statement. The file format specification will
be applied to all listed partitions, for example:
ALTER TABLE tbl ADD PARTITION (i=1) PARTITION (i=2) SET FILEFORMAT
PARQUET; will create two Parquet-formatted partition metadata
entries.

Tests:
 - analyzer test for the new syntax element
 - e2e test for adding partition in a specified format

Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
5 files changed, 62 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/19099/5
-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

A minor comment. Let's wait a bit in case Lipenglin has something else too.

http://gerrit.cloudera.org:8080/#/c/19099/5/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java:

http://gerrit.cloudera.org:8080/#/c/19099/5/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java@79
PS5, Line 79:  %s
Nit: if we're using a StringBuilder, maybe it's cleaner if we add " SET FILEFORMAT " and 'fileFormat' in two calls to sb.append() instead of string formatting.



-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Oct 2022 14:47:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/11548/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 08:42:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, lipenglin@sensorsdata.cn, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19099

to look at the new patch set (#6).

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................

IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

This change adds the possibility to set the partition file format
at creation by allowing to use the SET FORMAT clause at the end of
the ALTER TABLE ADD statement. The file format specification will
be applied to all listed partitions, for example:
ALTER TABLE tbl ADD PARTITION (i=1) PARTITION (i=2) SET FILEFORMAT
PARQUET; will create two Parquet-formatted partition metadata
entries.

Tests:
 - analyzer test for the new syntax element
 - e2e test for adding partition in a specified format

Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
5 files changed, 63 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/19099/6
-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11616/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 09:39:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 6: Code-Review+2

Thanks for solving this.


-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 13:10:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8692/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 13:11:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 5:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/11593/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Oct 2022 14:04:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11592/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Oct 2022 12:56:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11550/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 10:45:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/19099/3/common/thrift/JniCatalog.thrift
File common/thrift/JniCatalog.thrift:

http://gerrit.cloudera.org:8080/#/c/19099/3/common/thrift/JniCatalog.thrift@120
PS3, Line 120: ADD_PARTITION_SET_FILE_FORMAT = 22
> I agree, if it is possible we should reuse the existing class.
Done


http://gerrit.cloudera.org:8080/#/c/19099/3/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java:

http://gerrit.cloudera.org:8080/#/c/19099/3/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java@66
PS3, Line 66: if (tbl instanceof FeKuduTable) {
            :       throw new AnalysisException(
            :           "ALTER TABLE SET FILEFORMAT is not supported " + "on Kudu tables: "
            :               + tbl.getFullName());
            :     }
            : 
            :     if (tbl instanceof FeIcebergTable) {
            :       throw new AnalysisException(
            :           "ALTER TABLE SET FILEFORMAT is not supported " + "on Iceberg tables: "
            :               + tbl.getFullName());
            :     }
> Did you want to throw with a different message than in AlterTableAddPartiti
I removed this class and merged the new feature to AlterTableAddPartition.


http://gerrit.cloudera.org:8080/#/c/19099/3/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/19099/3/tests/metadata/test_ddl.py@646
PS3, Line 646:     # Add partition with different fileformat
> Can we validate that the new partition created really has the specified fil
A separate test case added to make the assertion more straightforward



-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Oct 2022 13:54:07 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 13:11:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )

Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19099/5/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java:

http://gerrit.cloudera.org:8080/#/c/19099/5/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java@79
PS5, Line 79:  %s
> Nit: if we're using a StringBuilder, maybe it's cleaner if we add " SET FIL
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69
Gerrit-Change-Number: 19099
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 09:20:11 +0000
Gerrit-HasComments: Yes