You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/30 14:53:39 UTC
[GitHub] [spark] tgravescs commented on pull request #29869: [SPARK-32994][CORE] Update external heavy accumulators before they entering into listener event loop
tgravescs commented on pull request #29869:
URL: https://github.com/apache/spark/pull/29869#issuecomment-701443248
I haven't looked at this in detail but you say there is no user facing changes but I don't think that's true. If a user names a accumulator in a certain way then it does something different correct? That is user impacting api and that would need to be documented somewhere. I'm personally not a fan of the word "heavy" here as I think its not clear as to what this means or consequences of it. I would also consider this a new feature not a bug fix since it introduces new api
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org