You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Akira AJISAKA (JIRA)" <ji...@apache.org> on 2015/01/05 05:22:34 UTC
[jira] [Commented] (HADOOP-11032) Replace use of Guava Stopwatch
with Apache StopWatch
[ https://issues.apache.org/jira/browse/HADOOP-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264171#comment-14264171 ]
Akira AJISAKA commented on HADOOP-11032:
----------------------------------------
Looks good to me, +1. The findbug warnings and test failure are not related to the patch.
We should edit the title because the patch does not use Apache StopWatch.
> Replace use of Guava Stopwatch with Apache StopWatch
> ----------------------------------------------------
>
> Key: HADOOP-11032
> URL: https://issues.apache.org/jira/browse/HADOOP-11032
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Gary Steelman
> Assignee: Tsuyoshi OZAWA
> Attachments: HADOOP-11032.1.patch, HADOOP-11032.2.patch, HADOOP-11032.3.patch, HADOOP-11032.3.patch, HADOOP-11032.3.patch, HADOOP-11032.3.patch, HADOOP-11032.3.patch, HADOOP-11032.4.patch, HADOOP-11032.5.patch, HADOOP-11032.6.patch, HADOOP-11032.7.patch, HADOOP-11032.8.patch
>
>
> This patch reduces Hadoop's dependency on an old version of guava. Stopwatch.elapsedMillis() isn't part of guava past v16 and the tools I'm working on use v17.
> To remedy this and also reduce Hadoop's reliance on old versions of guava, we can use the Apache StopWatch (org.apache.commons.lang.time.StopWatch) which provides nearly equivalent functionality. apache.commons.lang is already a dependency for Hadoop so this will not introduce new dependencies.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)