You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2010/07/02 23:03:49 UTC
[jira] Created: (WHIRR-53) Adopt the standard Java SPI interface
Adopt the standard Java SPI interface
-------------------------------------
Key: WHIRR-53
URL: https://issues.apache.org/jira/browse/WHIRR-53
Project: Whirr
Issue Type: Improvement
Components: core
Reporter: Tom White
Assignee: Tom White
Fix For: 0.1.0
The SPI implemented in WHIRR-47 makes it difficult to generate a executable JAR (for a CLI in WHIRR-33) since the whirr.properties files clobber each other. By implementing an SPI described in http://java.sun.com/j2se/1.3/docs/guide/jar/jar.html#Service%20Provider (or http://java.sun.com/j2se/1.4.2/docs/guide/sound/programmer_guide/chapter13.html) we can use the Maven Shade plugin to produce an executable JAR which avoids this problem (see http://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-53) Adopt the standard Java SPI interface
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885376#action_12885376 ]
Patrick Hunt commented on WHIRR-53:
-----------------------------------
+1, this looks good to me if you want to commit.
> Adopt the standard Java SPI interface
> -------------------------------------
>
> Key: WHIRR-53
> URL: https://issues.apache.org/jira/browse/WHIRR-53
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.1.0
>
> Attachments: WHIRR-53.patch
>
>
> The SPI implemented in WHIRR-47 makes it difficult to generate a executable JAR (for a CLI in WHIRR-33) since the whirr.properties files clobber each other. By implementing an SPI described in http://java.sun.com/j2se/1.3/docs/guide/jar/jar.html#Service%20Provider (or http://java.sun.com/j2se/1.4.2/docs/guide/sound/programmer_guide/chapter13.html) we can use the Maven Shade plugin to produce an executable JAR which avoids this problem (see http://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WHIRR-53) Adopt the standard Java SPI interface
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White resolved WHIRR-53.
----------------------------
Resolution: Fixed
I've just committed this.
> Adopt the standard Java SPI interface
> -------------------------------------
>
> Key: WHIRR-53
> URL: https://issues.apache.org/jira/browse/WHIRR-53
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.1.0
>
> Attachments: WHIRR-53.patch
>
>
> The SPI implemented in WHIRR-47 makes it difficult to generate a executable JAR (for a CLI in WHIRR-33) since the whirr.properties files clobber each other. By implementing an SPI described in http://java.sun.com/j2se/1.3/docs/guide/jar/jar.html#Service%20Provider (or http://java.sun.com/j2se/1.4.2/docs/guide/sound/programmer_guide/chapter13.html) we can use the Maven Shade plugin to produce an executable JAR which avoids this problem (see http://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-53) Adopt the standard Java SPI interface
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-53:
---------------------------
Attachment: WHIRR-53.patch
Here's an implementation. To use the ServiceLoader class I refactored Service (to give it a zero arg constructor). We may want to combine ClusterSpec and ServiceSpec now, but that could be done in a separate patch.
> Adopt the standard Java SPI interface
> -------------------------------------
>
> Key: WHIRR-53
> URL: https://issues.apache.org/jira/browse/WHIRR-53
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.1.0
>
> Attachments: WHIRR-53.patch
>
>
> The SPI implemented in WHIRR-47 makes it difficult to generate a executable JAR (for a CLI in WHIRR-33) since the whirr.properties files clobber each other. By implementing an SPI described in http://java.sun.com/j2se/1.3/docs/guide/jar/jar.html#Service%20Provider (or http://java.sun.com/j2se/1.4.2/docs/guide/sound/programmer_guide/chapter13.html) we can use the Maven Shade plugin to produce an executable JAR which avoids this problem (see http://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-53) Adopt the standard Java SPI interface
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884850#action_12884850 ]
Tom White commented on WHIRR-53:
--------------------------------
http://java.sun.com/javase/6/docs/api/java/util/ServiceLoader.html is the class to use.
> Adopt the standard Java SPI interface
> -------------------------------------
>
> Key: WHIRR-53
> URL: https://issues.apache.org/jira/browse/WHIRR-53
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.1.0
>
>
> The SPI implemented in WHIRR-47 makes it difficult to generate a executable JAR (for a CLI in WHIRR-33) since the whirr.properties files clobber each other. By implementing an SPI described in http://java.sun.com/j2se/1.3/docs/guide/jar/jar.html#Service%20Provider (or http://java.sun.com/j2se/1.4.2/docs/guide/sound/programmer_guide/chapter13.html) we can use the Maven Shade plugin to produce an executable JAR which avoids this problem (see http://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.