You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2016/08/14 02:19:33 UTC
[GitHub] incubator-quickstep pull request #92: Refactor Generators in Optimizer
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/92
Refactor Generators in Optimizer
Assigned to @jianqiao. Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep opt-refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/92.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #92
----
commit 49f014f4fafea26af1af87e25ca1c7b7d5f14884
Author: Zuyu Zhang <zu...@twitter.com>
Date: 2016-08-13T08:49:03Z
Removed unused StorageManager.
commit 572ba5911628f99b698e7f9560c39c449ffcf850
Author: Zuyu Zhang <zu...@twitter.com>
Date: 2016-08-13T22:16:32Z
Moved CatalogDatabase out of OptimizerContext.
commit b5798ed8e0bf4b0e083bb0437d2c25889644d9d2
Author: Zuyu Zhang <zu...@twitter.com>
Date: 2016-08-13T23:53:57Z
Moved OptimizerContext standalone.
commit d227e19e4b02e6d725782195ee0bcc9d143bc50c
Author: Zuyu Zhang <zu...@twitter.com>
Date: 2016-08-14T01:40:26Z
Removed unused OptimizerContext, and construct PhysicalGenerator once.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #92: Refactor Generators in Optimizer
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/92
@jianqiao I have added some descriptions as requested. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #92: Refactor Generators in Optimizer
Posted by jianqiao <gi...@git.apache.org>.
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/92
LGTM. Could you add a brief paragraph in this PR's top comment to describe the purpose of this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #92: Refactor Generators in Optimizer
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #92: Refactor Generators in Optimizer
Posted by jianqiao <gi...@git.apache.org>.
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/92
Just squashed and rebased the commits. Will merge it once travis-ci returns green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---