You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Antoine Pitrou (JIRA)" <ji...@apache.org> on 2018/04/10 13:35:00 UTC
[jira] [Updated] (ARROW-2442) [C++] Disambiguate Builder::Append
overloads
[ https://issues.apache.org/jira/browse/ARROW-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Pitrou updated ARROW-2442:
----------------------------------
Labels: beginner (was: )
> [C++] Disambiguate Builder::Append overloads
> --------------------------------------------
>
> Key: ARROW-2442
> URL: https://issues.apache.org/jira/browse/ARROW-2442
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 0.9.0
> Reporter: Antoine Pitrou
> Priority: Major
> Labels: beginner
>
> See discussion in [https://github.com/apache/arrow/pull/1852#discussion_r179919627]
> There are various {{Append()}} overloads in Builder and subclasses, some of which append one value, some of which append multiple values at once.
> The API might be clearer and less error-prone if multiple-append variants were named differently, for example {{AppendValues()}}. Especially with the pointer-taking variants, it's probably easy to call the wrong overload by mistake.
> The existing methods would have to go through a deprecation cycle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)