[GitHub] [spark] cloud-fan commented on a change in pull request #34758: [SPARK-37501][SQL] CREATE/REPLACE TABLE should qualify location for v2 command

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34758:
URL: https://github.com/apache/spark/pull/34758#discussion_r759831315



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateTableExec.scala
##########
@@ -42,7 +44,12 @@ case class CreateTableExec(
       tableSpec.properties, tableSpec.options, tableSpec.serde,
       tableSpec.location, tableSpec.comment, tableSpec.provider,
       tableSpec.external)
-    CatalogV2Util.withDefaultOwnership(props)
+    val newProps = props.get(TableCatalog.PROP_LOCATION).map { loc =>
+      props + (TableCatalog.PROP_LOCATION ->

Review comment:
       Can we be consistent and always qualify the path in `DataSourceV2Strategy`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org