You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Daniel Templeton (JIRA)" <ji...@apache.org> on 2016/09/20 21:27:20 UTC
[jira] [Comment Edited] (YARN-5659) getPathFromYarnURL should use
standard methods
[ https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507840#comment-15507840 ]
Daniel Templeton edited comment on YARN-5659 at 9/20/16 9:26 PM:
-----------------------------------------------------------------
Looks right to me. It would be really nice to add some unit tests to make sure the change isn't breaking anything.
was (Author: templedf):
Looks right to me. +1 (non-binding)
> getPathFromYarnURL should use standard methods
> ----------------------------------------------
>
> Key: YARN-5659
> URL: https://issues.apache.org/jira/browse/YARN-5659
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: YARN-5659.patch
>
>
> getPathFromYarnURL does some string shenanigans where standard ctors should suffice.
> There are also bugs in it e.g. passing an empty scheme to the URI ctor is invalid, null should be used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org