You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "my-ship-it (via GitHub)" <gi...@apache.org> on 2025/05/27 13:05:06 UTC
Re: [PR] ORCA: Support two step window function [cloudberry]
my-ship-it commented on code in PR #1014:
URL: https://github.com/apache/cloudberry/pull/1014#discussion_r2020502169
##########
src/backend/gporca/libgpopt/include/gpopt/base/CUtils.h:
##########
@@ -318,12 +318,10 @@ class CUtils
BOOL fNewComputedCol);
// generate a sequence project expression
- static CExpression *PexprLogicalSequenceProject(CMemoryPool *mp,
- CDistributionSpec *pds,
- COrderSpecArray *pdrgpos,
- CWindowFrameArray *pdrgpwf,
- CExpression *pexpr,
- CExpression *pexprPrjList);
+ static CExpression *PexprLogicalSequenceProject(
Review Comment:
Why change indention here?
##########
src/backend/gporca/libgpdbcost/src/CCostModelGPDB.cpp:
##########
@@ -1594,12 +1594,19 @@ CCostModelGPDB::CostSequenceProject(CMemoryPool *mp, CExpressionHandle &exprhdl,
GPOS_ASSERT(COperator::EopPhysicalSequenceProject ==
exprhdl.Pop()->Eopid());
+ CPhysicalSequenceProject *psp = CPhysicalSequenceProject::PopConvert(exprhdl.Pop());
+
+ if (GPOS_FTRACE(EopttraceForceSplitWindowFunc) &&
+ psp->Pspt() == COperator::EsptypeGlobalTwoStep) {
+ return CCost(0);
+ }
+
const DOUBLE num_rows_outer = pci->PdRows()[0];
const DOUBLE dWidthOuter = pci->GetWidth()[0];
ULONG ulSortCols = 0;
COrderSpecArray *pdrgpos =
- CPhysicalSequenceProject::PopConvert(exprhdl.Pop())->Pdrgpos();
+ CPhysicalSequenceProject::PopConvert(psp)->Pdrgpos();
Review Comment:
remove CPhysicalSequenceProject::PopConvert here?
##########
src/backend/gporca/libgpdbcost/src/CCostModelGPDB.cpp:
##########
@@ -1619,7 +1626,7 @@ CCostModelGPDB::CostSequenceProject(CMemoryPool *mp, CExpressionHandle &exprhdl,
dTupDefaultProcCostUnit));
CCost costChild =
CostChildren(mp, exprhdl, pci, pcmgpdb->GetCostModelParams());
-
+
Review Comment:
extra whitespace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org