You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alex Rudyy (JIRA)" <ji...@apache.org> on 2012/08/13 00:03:37 UTC
[jira] [Created] (QPID-4220) Use single json processing library
acrross all modules in java modules tree
Alex Rudyy created QPID-4220:
--------------------------------
Summary: Use single json processing library acrross all modules in java modules tree
Key: QPID-4220
URL: https://issues.apache.org/jira/browse/QPID-4220
Project: Qpid
Issue Type: Improvement
Components: Java Performance Tests
Affects Versions: 0.19
Reporter: Alex Rudyy
Assignee: Alex Rudyy
Priority: Minor
Currently java modules tree has dependencies on 2 json processing libraries: jackson and gson. jackson library is used in http management, gson is used in perftests library. In order to unify the usage of libraries and reduce the dependencies the perftests module needs to be changed to use jackson json parser and mapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4220) Use single json processing library
acrross all modules in java modules tree
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-4220:
-----------------------------
Attachment: (was: 0001-QPID-4220-Replace-gson-library-with-jackson-in-perft.patch)
> Use single json processing library acrross all modules in java modules tree
> ----------------------------------------------------------------------------
>
> Key: QPID-4220
> URL: https://issues.apache.org/jira/browse/QPID-4220
> Project: Qpid
> Issue Type: Improvement
> Components: Java Performance Tests
> Affects Versions: 0.19
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Attachments: 0001-QPID-4220-Replace-gson-library-with-jackson-in-perft.patch
>
>
> Currently java modules tree has dependencies on 2 json processing libraries: jackson and gson. jackson library is used in http management, gson is used in perftests library. In order to unify the usage of libraries and reduce the dependencies the perftests module needs to be changed to use jackson json parser and mapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4220) Use single json processing library
acrross all modules in java modules tree
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy reassigned QPID-4220:
--------------------------------
Assignee: Robbie Gemmell (was: Alex Rudyy)
Robbie,
Could you please review and commit the changes?
> Use single json processing library acrross all modules in java modules tree
> ----------------------------------------------------------------------------
>
> Key: QPID-4220
> URL: https://issues.apache.org/jira/browse/QPID-4220
> Project: Qpid
> Issue Type: Improvement
> Components: Java Performance Tests
> Affects Versions: 0.19
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Attachments: 0001-QPID-4220-Replace-gson-library-with-jackson-in-perft.patch
>
>
> Currently java modules tree has dependencies on 2 json processing libraries: jackson and gson. jackson library is used in http management, gson is used in perftests library. In order to unify the usage of libraries and reduce the dependencies the perftests module needs to be changed to use jackson json parser and mapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4220) Use single json processing library
acrross all modules in java modules tree
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-4220:
---------------------------------
Status: Open (was: Ready To Review)
> Use single json processing library acrross all modules in java modules tree
> ----------------------------------------------------------------------------
>
> Key: QPID-4220
> URL: https://issues.apache.org/jira/browse/QPID-4220
> Project: Qpid
> Issue Type: Improvement
> Components: Java Performance Tests
> Affects Versions: 0.19
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Attachments: 0001-QPID-4220-Replace-gson-library-with-jackson-in-perft.patch
>
>
> Currently java modules tree has dependencies on 2 json processing libraries: jackson and gson. jackson library is used in http management, gson is used in perftests library. In order to unify the usage of libraries and reduce the dependencies the perftests module needs to be changed to use jackson json parser and mapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4220) Use single json processing library
acrross all modules in java modules tree
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-4220:
-----------------------------
Attachment: 0001-QPID-4220-Replace-gson-library-with-jackson-in-perft.patch
Attached a patch removing the dependencies on gson json processor and replacing it with jackson json processor library.
The patch also normalizes the json files(both for testing and performance measuring) as I could not find a way to use mix of ; and , separators with jackson library.
Also, 2 unnecessary deserilizers are added for Response and RegisterClientCommand classes. The more optimal solution would be to add default constructors or annotations (I prefer the last) but I decided to go with deserializers in order to minimize changes in the framework
> Use single json processing library acrross all modules in java modules tree
> ----------------------------------------------------------------------------
>
> Key: QPID-4220
> URL: https://issues.apache.org/jira/browse/QPID-4220
> Project: Qpid
> Issue Type: Improvement
> Components: Java Performance Tests
> Affects Versions: 0.19
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Attachments: 0001-QPID-4220-Replace-gson-library-with-jackson-in-perft.patch
>
>
> Currently java modules tree has dependencies on 2 json processing libraries: jackson and gson. jackson library is used in http management, gson is used in perftests library. In order to unify the usage of libraries and reduce the dependencies the perftests module needs to be changed to use jackson json parser and mapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4220) Use single json processing library
acrross all modules in java modules tree
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-4220:
-----------------------------
Attachment: 0001-QPID-4220-Replace-gson-library-with-jackson-in-perft.patch
> Use single json processing library acrross all modules in java modules tree
> ----------------------------------------------------------------------------
>
> Key: QPID-4220
> URL: https://issues.apache.org/jira/browse/QPID-4220
> Project: Qpid
> Issue Type: Improvement
> Components: Java Performance Tests
> Affects Versions: 0.19
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Attachments: 0001-QPID-4220-Replace-gson-library-with-jackson-in-perft.patch
>
>
> Currently java modules tree has dependencies on 2 json processing libraries: jackson and gson. jackson library is used in http management, gson is used in perftests library. In order to unify the usage of libraries and reduce the dependencies the perftests module needs to be changed to use jackson json parser and mapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4220) Use single json processing library
acrross all modules in java modules tree
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-4220:
-----------------------------
Status: Ready To Review (was: In Progress)
> Use single json processing library acrross all modules in java modules tree
> ----------------------------------------------------------------------------
>
> Key: QPID-4220
> URL: https://issues.apache.org/jira/browse/QPID-4220
> Project: Qpid
> Issue Type: Improvement
> Components: Java Performance Tests
> Affects Versions: 0.19
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Attachments: 0001-QPID-4220-Replace-gson-library-with-jackson-in-perft.patch
>
>
> Currently java modules tree has dependencies on 2 json processing libraries: jackson and gson. jackson library is used in http management, gson is used in perftests library. In order to unify the usage of libraries and reduce the dependencies the perftests module needs to be changed to use jackson json parser and mapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4220) Use single json processing library
acrross all modules in java modules tree
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436684#comment-13436684 ]
Keith Wall commented on QPID-4220:
----------------------------------
Hi Alex,
As requested, I took a look of at your patch.
Like you, I'm a bit uncomfortable with the new custom deserialiser code in this patch, it looks quite fragile. I haven't used Jackson much, but I think I would take a look at annotations as I suspect this would end up being more robust.
I'm find with the json normalisation. I see no reason for the mixture in separators we have today. In fact, I'd be tempted to submit the json normalisation as a separate patch (same Jira) so we can commit immediately before it has chance to rot.
HTH.
> Use single json processing library acrross all modules in java modules tree
> ----------------------------------------------------------------------------
>
> Key: QPID-4220
> URL: https://issues.apache.org/jira/browse/QPID-4220
> Project: Qpid
> Issue Type: Improvement
> Components: Java Performance Tests
> Affects Versions: 0.19
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Attachments: 0001-QPID-4220-Replace-gson-library-with-jackson-in-perft.patch
>
>
> Currently java modules tree has dependencies on 2 json processing libraries: jackson and gson. jackson library is used in http management, gson is used in perftests library. In order to unify the usage of libraries and reduce the dependencies the perftests module needs to be changed to use jackson json parser and mapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4220) Use single json processing library
acrross all modules in java modules tree
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-4220:
------------------------------------
Assignee: Alex Rudyy (was: Robbie Gemmell)
> Use single json processing library acrross all modules in java modules tree
> ----------------------------------------------------------------------------
>
> Key: QPID-4220
> URL: https://issues.apache.org/jira/browse/QPID-4220
> Project: Qpid
> Issue Type: Improvement
> Components: Java Performance Tests
> Affects Versions: 0.19
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Attachments: 0001-QPID-4220-Replace-gson-library-with-jackson-in-perft.patch
>
>
> Currently java modules tree has dependencies on 2 json processing libraries: jackson and gson. jackson library is used in http management, gson is used in perftests library. In order to unify the usage of libraries and reduce the dependencies the perftests module needs to be changed to use jackson json parser and mapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org