You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Runping Qi (JIRA)" <ji...@apache.org> on 2008/03/25 03:13:24 UTC
[jira] Created: (HADOOP-3085) pushMetric() method of various metric
util classes should catch exceptions
pushMetric() method of various metric util classes should catch exceptions
--------------------------------------------------------------------------
Key: HADOOP-3085
URL: https://issues.apache.org/jira/browse/HADOOP-3085
Project: Hadoop Core
Issue Type: Bug
Components: metrics
Reporter: Runping Qi
pushMetric() method of various metric util classes should catch exception.
Otherwise, any misconfigured metric will cause the entire metric data not sent out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3085) pushMetric() method of various metric
util classes should catch exceptions
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3085:
----------------------------------
Status: Open (was: Patch Available)
> pushMetric() method of various metric util classes should catch exceptions
> --------------------------------------------------------------------------
>
> Key: HADOOP-3085
> URL: https://issues.apache.org/jira/browse/HADOOP-3085
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Reporter: Runping Qi
> Fix For: 0.18.0
>
> Attachments: 3085-0.patch, 3085-0.patch
>
>
> pushMetric() method of various metric util classes should catch exception.
> Otherwise, any misconfigured metric will cause the entire metric data not sent out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3085) pushMetric() method of various
metric util classes should catch exceptions
Posted by "Runping Qi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594339#action_12594339 ]
Runping Qi commented on HADOOP-3085:
------------------------------------
+1
The patch looks good.
> pushMetric() method of various metric util classes should catch exceptions
> --------------------------------------------------------------------------
>
> Key: HADOOP-3085
> URL: https://issues.apache.org/jira/browse/HADOOP-3085
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Reporter: Runping Qi
> Fix For: 0.18.0
>
> Attachments: 3085-0.patch, 3085-0.patch
>
>
> pushMetric() method of various metric util classes should catch exception.
> Otherwise, any misconfigured metric will cause the entire metric data not sent out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3085) pushMetric() method of various metric
util classes should catch exceptions
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3085:
----------------------------------
Attachment: 3085-0.patch
Whoops; bad patch. Resubmitting...
> pushMetric() method of various metric util classes should catch exceptions
> --------------------------------------------------------------------------
>
> Key: HADOOP-3085
> URL: https://issues.apache.org/jira/browse/HADOOP-3085
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Reporter: Runping Qi
> Fix For: 0.18.0
>
> Attachments: 3085-0.patch, 3085-0.patch
>
>
> pushMetric() method of various metric util classes should catch exception.
> Otherwise, any misconfigured metric will cause the entire metric data not sent out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3085) pushMetric() method of various
metric util classes should catch exceptions
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594880#action_12594880 ]
Hudson commented on HADOOP-3085:
--------------------------------
Integrated in Hadoop-trunk #483 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/483/])
> pushMetric() method of various metric util classes should catch exceptions
> --------------------------------------------------------------------------
>
> Key: HADOOP-3085
> URL: https://issues.apache.org/jira/browse/HADOOP-3085
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Reporter: Runping Qi
> Assignee: Chris Douglas
> Fix For: 0.18.0
>
> Attachments: 3085-0.patch, 3085-0.patch
>
>
> pushMetric() method of various metric util classes should catch exception.
> Otherwise, any misconfigured metric will cause the entire metric data not sent out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3085) pushMetric() method of various metric
util classes should catch exceptions
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3085:
----------------------------------
Status: Patch Available (was: Open)
> pushMetric() method of various metric util classes should catch exceptions
> --------------------------------------------------------------------------
>
> Key: HADOOP-3085
> URL: https://issues.apache.org/jira/browse/HADOOP-3085
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Reporter: Runping Qi
> Fix For: 0.18.0
>
> Attachments: 3085-0.patch, 3085-0.patch
>
>
> pushMetric() method of various metric util classes should catch exception.
> Otherwise, any misconfigured metric will cause the entire metric data not sent out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3085) pushMetric() method of various metric
util classes should catch exceptions
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3085:
----------------------------------
Fix Version/s: 0.18.0
Status: Patch Available (was: Open)
> pushMetric() method of various metric util classes should catch exceptions
> --------------------------------------------------------------------------
>
> Key: HADOOP-3085
> URL: https://issues.apache.org/jira/browse/HADOOP-3085
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Reporter: Runping Qi
> Fix For: 0.18.0
>
> Attachments: 3085-0.patch
>
>
> pushMetric() method of various metric util classes should catch exception.
> Otherwise, any misconfigured metric will cause the entire metric data not sent out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3085) pushMetric() method of various
metric util classes should catch exceptions
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593181#action_12593181 ]
Hadoop QA commented on HADOOP-3085:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381146/3085-0.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2345/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2345/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2345/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2345/console
This message is automatically generated.
> pushMetric() method of various metric util classes should catch exceptions
> --------------------------------------------------------------------------
>
> Key: HADOOP-3085
> URL: https://issues.apache.org/jira/browse/HADOOP-3085
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Reporter: Runping Qi
> Fix For: 0.18.0
>
> Attachments: 3085-0.patch, 3085-0.patch
>
>
> pushMetric() method of various metric util classes should catch exception.
> Otherwise, any misconfigured metric will cause the entire metric data not sent out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3085) pushMetric() method of various metric
util classes should catch exceptions
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3085:
----------------------------------
Resolution: Fixed
Assignee: Chris Douglas
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> pushMetric() method of various metric util classes should catch exceptions
> --------------------------------------------------------------------------
>
> Key: HADOOP-3085
> URL: https://issues.apache.org/jira/browse/HADOOP-3085
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Reporter: Runping Qi
> Assignee: Chris Douglas
> Fix For: 0.18.0
>
> Attachments: 3085-0.patch, 3085-0.patch
>
>
> pushMetric() method of various metric util classes should catch exception.
> Otherwise, any misconfigured metric will cause the entire metric data not sent out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3085) pushMetric() method of various metric
util classes should catch exceptions
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3085:
----------------------------------
Attachment: 3085-0.patch
This patch effects the fix suggested by the bug description, sending the exception to a common log instead of to stdout (as implemented in o.a.h.metrics.spi.AbstractMetricsContext::timerEvent).
> pushMetric() method of various metric util classes should catch exceptions
> --------------------------------------------------------------------------
>
> Key: HADOOP-3085
> URL: https://issues.apache.org/jira/browse/HADOOP-3085
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Reporter: Runping Qi
> Fix For: 0.18.0
>
> Attachments: 3085-0.patch
>
>
> pushMetric() method of various metric util classes should catch exception.
> Otherwise, any misconfigured metric will cause the entire metric data not sent out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3085) pushMetric() method of various
metric util classes should catch exceptions
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593101#action_12593101 ]
Hadoop QA commented on HADOOP-3085:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381127/3085-0.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs -1. The patch appears to cause Findbugs to fail.
core tests -1. The patch failed core unit tests.
contrib tests -1. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2341/testReport/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2341/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2341/console
This message is automatically generated.
> pushMetric() method of various metric util classes should catch exceptions
> --------------------------------------------------------------------------
>
> Key: HADOOP-3085
> URL: https://issues.apache.org/jira/browse/HADOOP-3085
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Reporter: Runping Qi
> Fix For: 0.18.0
>
> Attachments: 3085-0.patch
>
>
> pushMetric() method of various metric util classes should catch exception.
> Otherwise, any misconfigured metric will cause the entire metric data not sent out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.