Re: Floating a Possible BayesSQL Code Change for 3.1

[Justin Mason <jm...@jmason.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Daniel Quinlan writes:
> Michael Parker <pa...@pobox.com> writes:
> 
> > Just wanted to float this idea.  With the help of Matthew Schumacher
> > I've worked up a patch for BayesSQL that results in a fairly large speed
> > boost for the SQL based configurations.  I'm still running baseline and
> > new code benchmarks, but rough estimates put the speedup in the
> > neighborhood of 2x for MySQL and 4x for PostgreSQL.
> > 
> > The problem is that it involves some changes to _put_tokens, which is
> > the most called method in the BayesSQL code and adding an API method to
> > the BayesStore API.  Obviously not something to be taken lightly.
> > 
> > So, thoughts on getting this change into 3.1?  It would be HUGE in terms
> > of performance, that is the only reason I'm asking, otherwise I would
> > hold off for 3.2.
> 
> I would be fine with it as long as we get it into pre1 and if there
> are any issues, we yank it.

sounds fine to me, too.  adding private "shortcut" APIs if necessary
works fine.

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFC8Rb6MJF5cimLx9ARAskAAKCO3ljbuCF4do287RZDVF0EgYLtIwCePlyU
cr+3ZoG5LOgviwTqT3A4CwU=
=BleB
-----END PGP SIGNATURE-----