[GitHub] [spark] viirya commented on a change in pull request #31613: [SPARK-34476][SQL] Duplicate referenceNames are given for ambiguousReferences

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #31613:
URL: https://github.com/apache/spark/pull/31613#discussion_r581515619



##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/join.sql.out
##########
@@ -3225,7 +3225,7 @@ select * from
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-Reference 'f1' is ambiguous, could be: j.f1, j.f1.; line 2 pos 63
+Reference 'f1' is ambiguous, could be: j.f1#x, j.f1#x.; line 2 pos 63

Review comment:
       Does https://github.com/apache/spark/pull/31613/files#r581342459 answer @cloud-fan's question?
   
   So with the attr ID added, how it helps the case you show? I think it is the point we care about.
   
   BTW, what is `get_json_string`? Do you mean `get_json_object`?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org