You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ChristianSchulte <gi...@git.apache.org> on 2014/12/18 02:52:08 UTC
[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...
GitHub user ChristianSchulte opened a pull request:
https://github.com/apache/maven/pull/32
[MPIR-238] Addition of command line flag '--legacy-reactor-resolution'.
See http://jira.codehaus.org/browse/MPIR-238
This pull request will add a new command line flag '--legacy-reactor-resolution' to Maven to allow disabling workspace resolution. The name was choosen to be consistent with '--legacy-local-repositoy'.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChristianSchulte/maven master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit 1bc2602dc3e348399fbfa7bdd39b82fde3d95759
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-06-12T23:59:34Z
[MNG-2199] Version ranges not supported for parent artifacts
commit 0d51e693830e9d803e43b4bac155b958dc2bd343
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-06-14T01:22:47Z
Merge remote-tracking branch 'upstream/master'
commit 85ba5c0f4b5b28c425168a699bc5df6d89baecbf
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-07-01T22:12:58Z
Merge remote-tracking branch 'upstream/master'
commit 1615188e7eb2bc21141309dfa69bc57eec225473
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-07-05T13:25:09Z
Merge remote-tracking branch 'upstream/master'
commit 23e0de86814fa9dfb19ed9ef452f2f9bdb4da0ef
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-07-17T20:57:13Z
Merge remote-tracking branch 'upstream/master'
commit be46f8643eeb17c9cbb53e58a0e7a0942c1c8f04
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-12-17T23:56:51Z
Merge remote-tracking branch 'upstream/master'
commit 66ec29f3942048808a3415da9f82a18d71bd2f99
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-12-18T01:37:09Z
o Updated to add command line option '--legacy-reactor-resolution' to allow disabling workspace resolution introduced in Maven 3 as discussed at MPIR-238.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-75794059
Regarding the recent discussion about releasing 3.2.6 as 3.3.0: Could this be part of 3.3.0, please ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by hboutemy <gi...@git.apache.org>.
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-78220459
thank you for your work: the bugs are fixed now, cobertura-maven-plugin and m-site-p ITs pass
now back to the start of this PR :)
Christian: did you know about MPIR-322? I know it's not exactly what you are expecting with this PR, but does it already help (for my use cases, it helps...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-78281257
@jvanzyl: You would not want the `test-jar` goal to package compiled test classes instrumented by some reporting tool, would you ? So the forking logic needs to change in a way that a forked lifecycle will run isolated (e.g. with its own output directory). A rather incompatible change in the core requiring new reporting plugins. Something to be done in the next Maven version introducing a new POM version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-76101706
There's nothing wrong with there being a site plugin, configuration for the a site housed within the site plugin and running the site plugin. What is not right is how it was fused into the base level of the POM and not contained to its plugin and how it's special requirements have created several inconsistencies in the core that have made it hard to evolve. What is also not right is requiring special resolution magic for a specific plugin to run. You think that creating a special mode of resolution for one specific Maven plugin seems reasonable? I personally do not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-78277642
@ChristianSchulte Definitely more along the lines of what you describe where there is no site lifecycle. I think this is a design error in allowing non-build lifecycles. But yes, having the build produce data that can be consumed by other tools whether that be a reporting tool, metrics tool, or anything else is the way it should work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-76081933
Could not be more confusing.
Apache Maven is a software project management and comprehension tool. Based on the concept of a project object model (POM), Maven can manage a project's build, reporting and documentation from a central piece of information.
No more 'reporting and documentation' in the future makes the 'from a central piece of information' meaningless.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67438782
See http://jira.codehaus.org/browse/MNG-5738
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by hboutemy <gi...@git.apache.org>.
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-76888558
Reporting is a key feature of Maven I strongly want to keep working (or fix when we introduced problems while improving build consistency during Maven 3.x refactoring)
I like the option idea to fix (or workaround) the described use case, but I understand Jason resistance to adding it since it causes inconsistency. I still don't have strong final opinion if this is the way to go or not, either only as a temporary workaround or as a real permanent feature.
What I know is that, while working on maven-reporting-exec, ie the component that launches report mojos during site generation, in MSHARED-266 for version 1.2, I found that there were more than this resolution issue that makes reporting mojo execution a special case: build forking and aggregate are other special cases that cause issues, IMHO
And every change I could imagine to avoid build forking worked with most report plugins, but not with cobertura-maven-plugin: "producing artifacts or consuming artifacts" is a key factor, ie most reports are "consuming artifacts" but a few are "producing artifacts".
I imagine this idea about "disabling workspace resolution" will affect cobertura-maven-plugin: since this report is producing artifacts, it will require workspace resolution, isn't it?
Christian, did you try with a build that uses cobertura-maven-plugin?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-78283012
No, and I would not advocate the use of tools like that which would distort the standard lifecycle and promote tools like Jacoco that do not require things like that. As a tool that collaborates with the standard build lifecycle it should be able to operate on either data emitted by the eventing system in Maven or operate on, or use artifacts as they are produced from the system. Like adding an agent to dynamically instrument code. Tools like Clover and Cobertura are frankly terrible tools that are super hard to integrate and we've done some stupid things in the core to accommodate them and that was categorically a mistake. If things like Clover and Cobertura break in Maven 4.x I honestly don't care. They are designed incorrectly in my opinion or were designed for a time where there didn't exist proper support to be truly independent from how Maven operates. The model should be "report on standard data produced, or by looking at standard artifacts being produced", not I'm going t
o "jam myself into the process to completely alter how the build works to get the data I need."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte closed the pull request at:
https://github.com/apache/maven/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67625232
I don't agree. Why would you not want to build the site from the sources for the tag of the release you're building?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-78226219
I am really no fan of adding just another workaround.
@Jason: Are you suggesting to split site rendering from report data generation ? So the build lifecycle produces report data attached to the project picked up during site rendering ? Cobertura instrumentation takes place during the build lifecycle and site rendering picks up the data generated there without compiling and running any tests any more, for example ? Not talking about picking up data from the build output directory here but resolving that data based on e.g. classifiers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67614958
Can you explain why this is needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by hboutemy <gi...@git.apache.org>.
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-77110127
the current head is expected to be released soon: we'll need to investigate before releasing, IMHO
comparing 3.2.5 to actual head, slf4j version did not change: 1.7.5
when reading the changelog for head, this could perhaps be related to http://jira.codehaus.org/browse/MNG-5742 , which is the only issue I see that was intended to change classloading (this may of course be worse: unintented change when doing something else)
I tested with m-site-p ITs and found that the issue happen with m-javadoc-p too (without failing the build): see full-reporting IT output log:
[WARNING] An issue has occurred with maven-javadoc-plugin:2.9.1:javadoc, skipping LinkageError org/slf4j/spi/LocationAwareLogger, please report an issue to Maven dev team.
java.lang.NoClassDefFoundError: org/slf4j/spi/LocationAwareLogger
I created http://jira.codehaus.org/browse/MNG-5779 (as critical) to track the issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte closed the pull request at:
https://github.com/apache/maven/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...
Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67556876
It would be fine to reset the branch to the top of `origin/master`, cherry-pick your changes, start `rebase -i HEAD~2` and the squash both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-78341680
And I have been talking about this for years but have admittedly done nothing yet. But I believe the direction to go is to make some example data generators that can be used by tools to display the information. I think the site plugin has just grown into completely the wrong thing. It's generally terrible at generating standard doco as things like Jekyll just destroy it in terms of usability and community. Insofar as reporting it's just too invasive and it needs to be fully extracted from Maven's core so Maven can evolve. A personal goal is to entirely remove site/reporting logic from Maven's core in 4.x. This does not mean I want to wreck reporting but to create a facility that allow reporting tools to get at the data it needs to produce the reports that users expect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67626029
Feeding the tagged sources to the reports is not an issue. Feeding intermediate build results is. That's like the tagged sources changing with every build. Everything in `target/classes` is not identical to what is deployed to `central` . Different compiler version, different Maven version, shading, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-78013185
I chatted with Igor and he's going to try and change the way the classpath is constructed for plugins. The issue here appears to be forking where SLF4J is filtered out of the classpath which is going to cause issues. For in VM use the classrealm needs to be filtered because we're exporting from the core but while forking we'll leave the classpath untouched. We'll try that and see if the ITs all work and fixes this particular issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67622663
It is re-enabling the following workflow in Maven 3.
cmd> mvn release:prepare
cmd> mvn release:perform
Wait until the artifacts are synced to `central`. Then
cmd> mvn site-deploy
This should now deploy the site for the released artifacts from `central` and not some intermediate build result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67625978
irc.codehaus.org #maven-dev
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by Jason van Zyl <ja...@takari.io>.
Hervé,
After EclipseCon today I will look at the doco you started (much appreciated) and fill in some information. I'll try once again to get the release staged as well.
Do you think you can put the site plugin along with related plugins through it's paces with master to make sure we didn't miss anything? Igor tried to capture the case in the ITs for the Cobertura issue and if we can capture the other site related issues in a general way in the ITs we can make sure we don't bonk them again.
On Mar 10, 2015, at 7:55 AM, ifedorenko <gi...@git.apache.org> wrote:
> Github user ifedorenko commented on the pull request:
>
> https://github.com/apache/maven/pull/32#issuecomment-78070683
>
> http://jira.codehaus.org/browse/MNG-5783 should be fixed in master now. I've provided explanation of the problem and links to the fix and corresponding IT changes in the jira.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Takari and Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------
A master in the art of living draws no sharp distinction between his work and his play; his labor and his leisure; his mind and his body; his education and his recreation. He hardly knows which is which. He simply pursues his vision of excellence through whatever he is doing, and leaves others to determine whether he is working or playing. To himself, he always appears to be doing both.
-- François-René de Chateaubriand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ifedorenko <gi...@git.apache.org>.
Github user ifedorenko commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-78070683
http://jira.codehaus.org/browse/MNG-5783 should be fixed in master now. I've provided explanation of the problem and links to the fix and corresponding IT changes in the jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-75814137
I thought we agreed you were closing this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by hboutemy <gi...@git.apache.org>.
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-68146338
I completely understand Christian motivation: we have a problem when we need interaction between non-default lifecycle and default lifecycle
this causes multiple already opened issues:
http://jira.codehaus.org/browse/MPIR-238
http://jira.codehaus.org/browse/MJAVADOC-171
and this causes other problems that I'm starting to see without having opened a Jira issue at the moment: you cannot build a multi-module site independently from building the artifacts
then SHA-1 is incorrect, since the package has been rebuilt
I didn't have time to study the patch, I understand how the idea of this "legacy reactor resolution" isn't ideal, but it looks promising to wait for more complete solution (that will have deep impact, I fear)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-76933957
What's the state of the current head as of today ? I just wanted to test the cobertura plugin but cannot build the site with Maven 3.2.6-SNAPSHOT due to the following exception. That's happening with a released project known to work. So `mvn site -e` with Maven 3.2.5 succeeds whereas 3.2.6-SNAPSHOT fails.
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project jomc-parent: Execution default-site of goal org.apache.maven.plugins:maven-site-plugin:3.4:site failed: A required class was missing while executing org.apache.maven.plugins:maven-site-plugin:3.4:site: org/slf4j/spi/LocationAwareLogger
```
```
Caused by: java.lang.NoClassDefFoundError: org/slf4j/spi/LocationAwareLogger
at org.apache.commons.logging.impl.SLF4JLogFactory.getInstance(SLF4JLogFactory.java:157)
at org.apache.commons.logging.LogFactory.getLog(LogFactory.java:289)
at org.apache.commons.digester.Digester.<init>(Digester.java:308)
at org.apache.velocity.tools.config.XmlFactoryConfiguration.read(XmlFactoryConfiguration.java:117)
at org.apache.velocity.tools.config.FileFactoryConfiguration.read(FileFactoryConfiguration.java:140)
at org.apache.velocity.tools.config.FileFactoryConfiguration.read(FileFactoryConfiguration.java:116)
at org.apache.velocity.tools.config.FileFactoryConfiguration.read(FileFactoryConfiguration.java:91)
at org.apache.velocity.tools.config.FileFactoryConfiguration.read(FileFactoryConfiguration.java:69)
at org.apache.velocity.tools.config.FileFactoryConfiguration.read(FileFactoryConfiguration.java:59)
at org.apache.velocity.tools.config.ConfigurationUtils.getDefaultTools(ConfigurationUtils.java:79)
at org.apache.velocity.tools.config.ConfigurationUtils.getAutoLoaded(ConfigurationUtils.java:176)
at org.apache.velocity.tools.ToolManager.autoConfigure(ToolManager.java:74)
at org.apache.velocity.tools.ToolManager.<init>(ToolManager.java:68)
at org.apache.velocity.tools.ToolManager.<init>(ToolManager.java:59)
at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.createVelocityContext(DefaultSiteRenderer.java:427)
at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.generateDocument(DefaultSiteRenderer.java:565)
at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderDocument(DefaultSiteRenderer.java:422)
at org.apache.maven.doxia.siterenderer.DoxiaDocumentRenderer.renderDocument(DoxiaDocumentRenderer.java:51)
at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:311)
at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:129)
at org.apache.maven.plugins.site.render.SiteMojo.renderDoxiaDocuments(SiteMojo.java:261)
at org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:172)
at org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:141)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
... 21 more
Caused by: java.lang.ClassNotFoundException: org.slf4j.spi.LocationAwareLogger
at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
... 45 more
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-77428933
I have no experience with the cobertura plugin. I just added
```
<reportPlugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>cobertura-maven-plugin</artifactId>
<version>2.7</version>
</reportPlugin>
```
to the configuration of the site plugin of a working project. Executing `mvn site -e` with Maven 3.2.5, site building succeeds. Using Maven 3.3.0-SNAPSHOT with the latest changes to head, the following exception is thrown.
```
[ERROR] Exception in thread "main" java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory
at net.sourceforge.cobertura.instrument.InstrumentMain$LoggerWrapper.<init>(InstrumentMain.java:165)
at net.sourceforge.cobertura.instrument.InstrumentMain$LoggerWrapper.<init>(InstrumentMain.java:164)
at net.sourceforge.cobertura.instrument.InstrumentMain.<clinit>(InstrumentMain.java:66)
Caused by: java.lang.ClassNotFoundException: org.slf4j.LoggerFactory
at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
... 3 more
```
That exception is not thrown using Maven 3.2.5. There still seems to be a class loading issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by hboutemy <gi...@git.apache.org>.
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-77440946
yes, it was just fixed in http://jira.codehaus.org/browse/MNG-5779
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-75990941
There are situations the behaviour is not wrong, in my opinion. Resolution for non project `<packaging>` related lifecycles, for example. Maven could detect this automically based on various criteria: not the default lifecycle, not project packaging related, attribute of a lifecycle, not executed at an even hour, etc but it does not. No issue. The command line option lets you choose the needed behaviour yourself without being forced (issue!) by Maven to anything. I can live with this not getting committed. That's not the point. For me that standalone site building tool would exactly be `mvn --legacy-reactor-resolution site`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-75814030
No, I don't think it's a good idea to be honest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67621964
I'm not really in favour of this change. This seems entirely wrong to change the way resolution works for the site plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by hboutemy <gi...@git.apache.org>.
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-77975130
another issue found regarding slf4j, this time with cobertura plugin, during instrumentation http://jira.codehaus.org/browse/MNG-5783 created, with the difference in {{Populating class realm plugin>org.codehaus.mojo:cobertura-maven-plugin:2.8-SNAPSHOT}}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by mcculls <gi...@git.apache.org>.
Github user mcculls commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-77430685
@ChristianSchulte I believe that was recently fixed in master: https://github.com/apache/maven/commit/57a6196422873eaf2f00a282b33894a74dcfd19c
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67621081
I would need a way to disable workspace resolution mainly for the `site` lifecycle.
cmd> svn checkout .../tags/maven-3.0
cmd> cd maven-3.0
cmd> mvn site
This feeds intermediate build results to the various reports thrown away right after site generation whereas
cmd> mvn --legacy-reactor-resolution site
makes Maven 3 download the artifacts from `central` or fail, if not finding them.
Feeding the released artifacts to the various reports is the expected behaviour in my opinion as the reports are now generated using the same released artifacts instead of some intermediate build result. The `site` lifecycle does not produce any artifacts. It consumes pre-built artifacts and should really fail, if those artifacts cannot be found. Maven 2 did the right thing here, in my opinion. I would always execute `mvn --legacy-reactor-resolution site` with this option available.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
GitHub user ChristianSchulte reopened a pull request:
https://github.com/apache/maven/pull/32
[MPIR-238] Addition of command line flag '--legacy-reactor-resolution'.
See http://jira.codehaus.org/browse/MPIR-238
This pull request will add a new command line flag '--legacy-reactor-resolution' to Maven to allow disabling workspace resolution. The name was choosen to be consistent with '--legacy-local-repositoy'.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChristianSchulte/maven master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit 1bc2602dc3e348399fbfa7bdd39b82fde3d95759
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-06-12T23:59:34Z
[MNG-2199] Version ranges not supported for parent artifacts
commit 0d51e693830e9d803e43b4bac155b958dc2bd343
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-06-14T01:22:47Z
Merge remote-tracking branch 'upstream/master'
commit 85ba5c0f4b5b28c425168a699bc5df6d89baecbf
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-07-01T22:12:58Z
Merge remote-tracking branch 'upstream/master'
commit 1615188e7eb2bc21141309dfa69bc57eec225473
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-07-05T13:25:09Z
Merge remote-tracking branch 'upstream/master'
commit 23e0de86814fa9dfb19ed9ef452f2f9bdb4da0ef
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-07-17T20:57:13Z
Merge remote-tracking branch 'upstream/master'
commit be46f8643eeb17c9cbb53e58a0e7a0942c1c8f04
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-12-17T23:56:51Z
Merge remote-tracking branch 'upstream/master'
commit 66ec29f3942048808a3415da9f82a18d71bd2f99
Author: Christian Schulte <cs...@schulte.it>
Date: 2014-12-18T01:37:09Z
o Updated to add command line option '--legacy-reactor-resolution' to allow disabling workspace resolution introduced in Maven 3 as discussed at MPIR-238.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67459407
Are you referring to
git rebase -i upstream/master
then squash all commits and push that ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67625161
Maybe the proper solution would be to control this behaviour based on an attribute of the lifecycle ? So a lifecycle can be flagged as producing artifacts or as consuming artifacts. Lifecycles producing artifacts behave like Maven 3. Lifecycles consuming artifacts behave like Maven 2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-76013680
The crux of my argument is that Maven should not be doing anything other than building, non build lifecycles were a mistake and have done nothing but make the core more complex and make it harder to evolve. Generating a site is just an invocation of a tool, it's not a lifecycle. The site plugin lives somewhere between the core and a more sophisticated plugin and honestly has just become a huge mess. If you want to make a stand-alone site tool, then it should be so and not require magical features in Maven core.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-75961215
The behaviour you describe you need is wrong and the I'm convinced at this point that the site plugin should just be a stand-alone tool and was implemented incorrectly in Maven 2.x as a lifecycle and it continues to pervert Maven core and that everything to do with reporting should be ripped out of the core once and for all. I will help extract the logic out of core and help make the Site plugin an independent tool, but I'm not integrating this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67625959
Maybe jump in IRC, probably easier to chat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-75848081
I am still convinced that it is a good idea to allow Maven 3 'mvn site-deploy' to work the same way as Maven 2. What's the issue with that ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...
Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67453526
Christian, can you squash your commits please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-76122905
```
parent
module1
module2
```
With Maven 3 I need to
```
cmd>cd parent && mvn site-deploy -N && cd module1 && mvn site-deploy && cd ../module2 && mvn site-deploy
```
to get the same behaviour as executing
```
cmd>cd parent && mvn site-deploy
```
with Maven 2. So in Maven 3 I would like to
```
cmd>cd parent && mvn --legacy-reactor-resolution site-deploy
```
Pretty much the same way the following command line flag can be used to make Maven 3 behave the same way as Maven 2.
```
-llr,--legacy-local-repository Use Maven 2 Legacy Local
Repository behaviour, ie no use of
_remote.repositories. Can also be
activated by using
-Dmaven.legacyLocalRepo=true
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-78290027
I totally agree with this. Do not cripple Maven to support bad ideas or concepts. "Supported by Maven" as an indicator for something. Not supported by Maven so not worth integrating means Maven must be ideal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-67605975
Rebased and then pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org