You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/16 00:37:40 UTC
[GitHub] [hbase] sguggilam opened a new pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
sguggilam opened a new pull request #2076:
URL: https://github.com/apache/hbase/pull/2076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] sguggilam commented on a change in pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
sguggilam commented on a change in pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#discussion_r456104565
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java
##########
@@ -343,6 +343,13 @@ private void load() throws IOException {
}
}
+ /**
+ * Sets the status task for monitoring all the subtasks for Snapshot operation
+ */
+ public void setMonitoredTask(MonitoredTask statusTask) {
Review comment:
There are few other places where create method is getting called in src and test classes. I just thought this would be easier for the callers to set the status as optional when needed instead of passing in to the create call where everyone has pass in null explicitly in the absence of task object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] sguggilam commented on pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
sguggilam commented on pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#issuecomment-659700387
> Looks good overall, few minor nits. We are planning PR for master branch also?
Yes @virajjasani , we can commit this PR for master branch as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv commented on a change in pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#discussion_r455459886
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
##########
@@ -624,14 +623,16 @@ private void takeSnapshotInternal(SnapshotDescription snapshot) throws IOExcepti
AssignmentManager assignmentMgr = master.getAssignmentManager();
if (assignmentMgr.getTableStateManager().isTableState(snapshotTable,
ZooKeeperProtos.Table.State.ENABLED)) {
- LOG.debug("Table enabled, starting distributed snapshot.");
+ LOG.debug("Table enabled, starting distributed snapshot for "
Review comment:
branch-1 doesn't support parameterized logging, so wrap with LOG.isDebugEnabled() checks? Saves string construction when debug logging isn't enabled. (multiple places).
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java
##########
@@ -343,6 +343,13 @@ private void load() throws IOException {
}
}
+ /**
+ * Sets the status task for monitoring all the subtasks for Snapshot operation
+ */
+ public void setMonitoredTask(MonitoredTask statusTask) {
Review comment:
Any reason to have a separate setter instead of passing it via create() ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#discussion_r456480852
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java
##########
@@ -343,6 +343,13 @@ private void load() throws IOException {
}
}
+ /**
+ * Sets the status task for monitoring all the subtasks for Snapshot operation
+ */
+ public void setMonitoredTask(MonitoredTask statusTask) {
Review comment:
+1
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredTaskImpl.java
##########
@@ -18,15 +18,13 @@
*/
package org.apache.hadoop.hbase.monitoring;
-import org.apache.hadoop.hbase.classification.InterfaceAudience;
-
import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
-
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
Review comment:
This also looks formatter's doing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] sguggilam commented on a change in pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
sguggilam commented on a change in pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#discussion_r456104808
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
##########
@@ -624,14 +623,16 @@ private void takeSnapshotInternal(SnapshotDescription snapshot) throws IOExcepti
AssignmentManager assignmentMgr = master.getAssignmentManager();
if (assignmentMgr.getTableStateManager().isTableState(snapshotTable,
ZooKeeperProtos.Table.State.ENABLED)) {
- LOG.debug("Table enabled, starting distributed snapshot.");
+ LOG.debug("Table enabled, starting distributed snapshot for "
Review comment:
Makes sense , updated in latest patch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#discussion_r455697655
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java
##########
@@ -343,6 +343,13 @@ private void load() throws IOException {
}
}
+ /**
+ * Sets the status task for monitoring all the subtasks for Snapshot operation
+ */
+ public void setMonitoredTask(MonitoredTask statusTask) {
Review comment:
Passing with create() sounds good, this class is anyways IA.Private, we can add new argument to public methods.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
##########
@@ -34,22 +37,21 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.ReadWriteLock;
import java.util.concurrent.locks.ReentrantReadWriteLock;
-
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import org.apache.hadoop.hbase.classification.InterfaceAudience;
-import org.apache.hadoop.hbase.classification.InterfaceStability;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FSDataInputStream;
import org.apache.hadoop.fs.FileStatus;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
-import org.apache.hadoop.hbase.TableName;
import org.apache.hadoop.hbase.HBaseInterfaceAudience;
import org.apache.hadoop.hbase.HConstants;
import org.apache.hadoop.hbase.HTableDescriptor;
-import org.apache.hadoop.hbase.Stoppable;
import org.apache.hadoop.hbase.MetaTableAccessor;
+import org.apache.hadoop.hbase.Stoppable;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.classification.InterfaceStability;
Review comment:
looks like import reorder is due to formatter :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#issuecomment-659693967
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 41s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 49s | branch-1 passed |
| +1 :green_heart: | compile | 0m 40s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | compile | 0m 46s | branch-1 passed with JDK v1.7.0_262 |
| +1 :green_heart: | checkstyle | 1m 41s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 2s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 50s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 0m 41s | branch-1 passed with JDK v1.7.0_262 |
| +0 :ok: | spotbugs | 3m 3s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 0s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 56s | the patch passed |
| +1 :green_heart: | compile | 0m 42s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javac | 0m 42s | the patch passed |
| +1 :green_heart: | compile | 0m 44s | the patch passed with JDK v1.7.0_262 |
| +1 :green_heart: | javac | 0m 44s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 28s | hbase-server: The patch generated 0 new + 20 unchanged - 10 fixed = 20 total (was 30) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 46s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 45s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 32s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 0m 44s | the patch passed with JDK v1.7.0_262 |
| +1 :green_heart: | findbugs | 2m 54s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 133m 40s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. |
| | | 175m 40s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2076 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 34822685206c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2076/out/precommit/personality/provided.sh |
| git revision | branch-1 / 71aec0f |
| Default Java | 1.7.0_262 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/2/testReport/ |
| Max. process+thread count | 4488 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/2/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv merged pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
bharathv merged pull request #2076:
URL: https://github.com/apache/hbase/pull/2076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] sguggilam commented on pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
sguggilam commented on pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#issuecomment-659087056
@apurtell @bharathv @virajjasani Can you please review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#issuecomment-660312944
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 43s | branch-1 passed |
| +1 :green_heart: | compile | 0m 41s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | compile | 0m 44s | branch-1 passed with JDK v1.7.0_262 |
| +1 :green_heart: | checkstyle | 1m 40s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 1s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 47s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 0m 42s | branch-1 passed with JDK v1.7.0_262 |
| +0 :ok: | spotbugs | 2m 58s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 2m 55s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 54s | the patch passed |
| +1 :green_heart: | compile | 0m 43s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javac | 0m 43s | the patch passed |
| +1 :green_heart: | compile | 0m 44s | the patch passed with JDK v1.7.0_262 |
| +1 :green_heart: | javac | 0m 44s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 29s | hbase-server: The patch generated 0 new + 20 unchanged - 10 fixed = 20 total (was 30) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 47s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 34s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 31s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 0m 43s | the patch passed with JDK v1.7.0_262 |
| +1 :green_heart: | findbugs | 2m 49s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 132m 0s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. |
| | | 173m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2076 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 76406a1354d4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2076/out/precommit/personality/provided.sh |
| git revision | branch-1 / 37903b0 |
| Default Java | 1.7.0_262 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/3/testReport/ |
| Max. process+thread count | 4280 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/3/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] liuml07 commented on a change in pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
liuml07 commented on a change in pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#discussion_r456248801
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java
##########
@@ -343,6 +343,13 @@ private void load() throws IOException {
}
}
+ /**
+ * Sets the status task for monitoring all the subtasks for Snapshot operation
+ */
+ public void setMonitoredTask(MonitoredTask statusTask) {
Review comment:
It seems more straight to readers if we pass this in the `create()`. Also this class field can be final then. @sguggilam We can have two versions of `create()` I guess? The one supporting those call sites which do not need monitored task does not need to change.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredTaskImpl.java
##########
@@ -18,15 +18,13 @@
*/
package org.apache.hadoop.hbase.monitoring;
-import org.apache.hadoop.hbase.classification.InterfaceAudience;
-
import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
-
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
Review comment:
Is this required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] sguggilam commented on pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
sguggilam commented on pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#issuecomment-659086947
Sample Journal entry:
Table snapshot journal :
Running FLUSH table snapshot test_snapshot C_M_SNAPSHOT_TABLE on table test at 1594859523584
Consolidate snapshot: test_snapshot at 1594859523691 (+107 ms)
Loading Region manifests for test_snapshot at 1594859523692 (+1 ms)
Writing data manifest for test_snapshot at 1594859523693 (+1 ms)
Verifying snapshot: test_snapshot at 1594859523706 (+13 ms)
Snapshot test_snapshot of table test completed at 1594859523710 (+4 ms)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#issuecomment-659089050
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 0m 7s | Docker failed to build yetus/hbase:7cf97016b9. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/2076 |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/1/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] liuml07 commented on pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation
Posted by GitBox <gi...@apache.org>.
liuml07 commented on pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#issuecomment-660234327
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org