[jira] [Comment Edited] (FLINK-10050) Support 'allowedLateness' in CoGroupedStreams

["eugen yushin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601172#comment-16601172 ] 

eugen yushin edited comment on FLINK-10050 at 9/2/18 10:28 AM:
---------------------------------------------------------------

[~aljoscha], [~till.rohrmann]
 Guys, please can you take a look at PR?
 I didn't add unit tests because of:
 a. there're no mock tests for referenced files in master branch to cover such kind of delegates as evictor/trigger/...
 b. 'allowedLateness' is a feature of WindowedStream, and proposed fix simply delegates all the work to WindowedStream logic

Regards


was (Author: eyushin):
[~aljoscha], [~till.rohrmann]
Guys, please can you take a look at PR?
I didn't add unit tests because of:
a. there're no mock tests for referenced files in master branch to cover such kind of delegates as evictor/trigger/...
b. 'allowedLateness' is an feature of WindowedStream, and proposed fix simply delegates all the work to WindowedStream logic

Regards

> Support 'allowedLateness' in CoGroupedStreams
> ---------------------------------------------
>
>                 Key: FLINK-10050
>                 URL: https://issues.apache.org/jira/browse/FLINK-10050
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: eugen yushin
>            Priority: Major
>              Labels: pull-request-available, ready-to-commit, windows
>
> WindowedStream has a support of 'allowedLateness' feature, while CoGroupedStreams are not. At the mean time, WindowedStream is an inner part of CoGroupedStreams and all main functionality (like evictor/trigger/...) is simply delegated to WindowedStream.
> There's no chance to operate with late arriving data from previous steps in cogroups (and joins). Consider the following flow:
> a. read data from source1 -> aggregate data with allowed lateness
> b. read data from source2 -> aggregate data with allowed lateness
> c. cogroup/join streams a and b, and compare aggregated values
> Step c doesn't accept any late data from steps a/b due to lack of `allowedLateness` API call in CoGroupedStreams.java.
> Scope: add method `WithWindow.allowedLateness` to Java API (flink-streaming-java) and extend scala API (flink-streaming-scala).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)