You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/24 19:49:53 UTC
[GitHub] [pulsar] eolivelli commented on a diff in pull request #15757: Issue 15750: PIP-105: Store Subscription properties
eolivelli commented on code in PR #15757:
URL: https://github.com/apache/pulsar/pull/15757#discussion_r880892876
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -361,6 +369,18 @@ public void operationComplete(ManagedCursorInfo info, Stat stat) {
cursorLedgerStat = stat;
lastActive = info.getLastActive() != 0 ? info.getLastActive() : lastActive;
+
+ Map<String, String> recoveredCursorProperties = Collections.emptyMap();
+ if (info.getCursorPropertiesCount() > 0) {
+ // Recover properties map
+ recoveredCursorProperties = Maps.newHashMap();
Review Comment:
Collections.emptyMap() returns a singleton immutable map not a mutable HashMap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org