You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "evgeniy-b (via GitHub)" <gi...@apache.org> on 2026/03/16 14:25:25 UTC
[PR] Fix BigQueryInsertJobTrigger not propagating CancelledError [airflow]
evgeniy-b opened a new pull request, #63730:
URL: https://github.com/apache/airflow/pull/63730
The `except asyncio.CancelledError` block in `BigQueryInsertJobTrigger.run()` catches the exception to perform cleanup (cancelling the BQ job) but never re-raises it. This causes the cancellation to be silently dropped β the triggerer framework never knows the trigger was cancelled.
Added `raise` after cleanup to propagate the error. Updated tests to assert the exception is raised.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes β Claude Opus 4.6
Generated-by: Claude Opus 4.6 following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BigQueryInsertJobTrigger not propagating CancelledError [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #63730:
URL: https://github.com/apache/airflow/pull/63730#issuecomment-4068050288
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BigQueryInsertJobTrigger not propagating CancelledError [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 merged PR #63730:
URL: https://github.com/apache/airflow/pull/63730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BigQueryInsertJobTrigger not propagating CancelledError [airflow]
Posted by "evgeniy-b (via GitHub)" <gi...@apache.org>.
evgeniy-b commented on code in PR #63730:
URL: https://github.com/apache/airflow/pull/63730#discussion_r2987378563
##########
providers/google/tests/unit/google/cloud/triggers/test_bigquery.py:
##########
@@ -258,11 +258,9 @@ async def test_bigquery_insert_job_trigger_cancellation(
caplog.set_level(logging.INFO)
- try:
+ with pytest.raises(asyncio.CancelledError):
async for _ in insert_job_trigger.run():
pass
- except asyncio.CancelledError:
- pass
Review Comment:
Previous implementation was silently skipping `CancelledError` (except -> pass). The tests would ignore it if the exception was raised.
The change ensures that the run() raises `CancelledError` by wrapping in `pytest.raises`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BigQueryInsertJobTrigger not propagating CancelledError [airflow]
Posted by "evgeniy-b (via GitHub)" <gi...@apache.org>.
evgeniy-b commented on PR #63730:
URL: https://github.com/apache/airflow/pull/63730#issuecomment-4154638299
@shahar1 , could you please have a look at the pr when you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BigQueryInsertJobTrigger not propagating CancelledError [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #63730:
URL: https://github.com/apache/airflow/pull/63730#issuecomment-4381144887
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BigQueryInsertJobTrigger not propagating CancelledError [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #63730:
URL: https://github.com/apache/airflow/pull/63730#discussion_r2973097889
##########
providers/google/tests/unit/google/cloud/triggers/test_bigquery.py:
##########
@@ -258,11 +258,9 @@ async def test_bigquery_insert_job_trigger_cancellation(
caplog.set_level(logging.INFO)
- try:
+ with pytest.raises(asyncio.CancelledError):
async for _ in insert_job_trigger.run():
pass
- except asyncio.CancelledError:
- pass
Review Comment:
This also does not verify the reraise actually works. The tests would pass even without the change to bigquery.py.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BigQueryInsertJobTrigger not propagating CancelledError [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #63730:
URL: https://github.com/apache/airflow/pull/63730#discussion_r2973094868
##########
providers/google/tests/unit/google/cloud/triggers/test_bigquery.py:
##########
@@ -258,11 +258,9 @@ async def test_bigquery_insert_job_trigger_cancellation(
caplog.set_level(logging.INFO)
- try:
+ with pytest.raises(asyncio.CancelledError):
async for _ in insert_job_trigger.run():
pass
- except asyncio.CancelledError:
- pass
Review Comment:
I donβt think this should be changed? Same for the other similar change below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BigQueryInsertJobTrigger not propagating CancelledError [airflow]
Posted by "evgeniy-b (via GitHub)" <gi...@apache.org>.
evgeniy-b commented on code in PR #63730:
URL: https://github.com/apache/airflow/pull/63730#discussion_r2987384277
##########
providers/google/tests/unit/google/cloud/triggers/test_bigquery.py:
##########
@@ -258,11 +258,9 @@ async def test_bigquery_insert_job_trigger_cancellation(
caplog.set_level(logging.INFO)
- try:
+ with pytest.raises(asyncio.CancelledError):
async for _ in insert_job_trigger.run():
pass
- except asyncio.CancelledError:
- pass
Review Comment:
So the tests will fail without the implementation change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org