You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2017/06/09 11:29:08 UTC

[jclouds/jclouds] Improve OS detection and SSH configuration in Packet (#1112)

* Adds Alpine Linux as a known OSFamily to jclouds-compute, and improves the OS detection in Packet.
* Packet has an API to set the key pairs, so this PR removes the default script that implicitly uploads the key via SSH if it is configured in the options.
* Also removes a couple unused classes.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1112

-- Commit Summary --

  * Improve OS detection and SSH configuration in Packet

-- File Changes --

    M compute/src/main/java/org/jclouds/compute/domain/OsFamily.java (2)
    M providers/packet/src/main/java/org/jclouds/packet/compute/config/PacketComputeServiceContextModule.java (4)
    M providers/packet/src/main/java/org/jclouds/packet/compute/functions/OperatingSystemToImage.java (48)
    D providers/packet/src/main/java/org/jclouds/packet/domain/ActionType.java (39)
    D providers/packet/src/main/java/org/jclouds/packet/domain/Distribution.java (68)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1112.patch
https://github.com/jclouds/jclouds/pull/1112.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1112

Re: [jclouds/jclouds] Improve OS detection and SSH configuration in Packet (#1112)

Posted by Ignasi Barrera <no...@github.com>.

Merged to master and 2.0.x. The packet specific parts for 2.0.x have been pushed to the jclouds-labs repo.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1112#issuecomment-307703127

Re: [jclouds/jclouds] Improve OS detection and SSH configuration in Packet (#1112)

Posted by Andrea Turli <no...@github.com>.

andreaturli commented on this pull request.



> - * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jclouds.packet.domain;
-
-/**
- * Performs an action for the given device. Possible actions include:
-
- power_on
- power_off
- reboot
- rescue: reboot the device into rescue OS.
- */
-public enum ActionType {

is this not needed anymore?

> @@ -80,6 +81,7 @@ protected void configure() {
       });
       bind(TemplateOptions.class).to(PacketTemplateOptions.class);
       bind(CreateNodesInGroupThenAddToSet.class).to(CreateSshKeysThenCreateNodes.class);
+      bind(NodeAndTemplateOptionsToStatement.class).to(NodeAndTemplateOptionsToStatementWithoutPublicKey.class);

didn't know that! :)

looks quite useful! thanks

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1112#pullrequestreview-43193697

Re: [jclouds/jclouds] Improve OS detection and SSH configuration in Packet (#1112)

Posted by Ignasi Barrera <no...@github.com>.

Closed #1112.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1112#event-1118895074

Re: [jclouds/jclouds] Improve OS detection and SSH configuration in Packet (#1112)

Posted by Ignasi Barrera <no...@github.com>.

nacx commented on this pull request.



> - * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jclouds.packet.domain;
-
-/**
- * Performs an action for the given device. Possible actions include:
-
- power_on
- power_off
- reboot
- rescue: reboot the device into rescue OS.
- */
-public enum ActionType {

It wasn't used anywhere

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1112#discussion_r121162566

Re: [jclouds/jclouds] Improve OS detection and SSH configuration in Packet (#1112)

Posted by Andrea Turli <no...@github.com>.

lgtm +1

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1112#issuecomment-307474960

Re: [jclouds/jclouds] Improve OS detection and SSH configuration in Packet (#1112)

Posted by Andrea Turli <no...@github.com>.

andreaturli commented on this pull request.



> - * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jclouds.packet.domain;
-
-/**
- * Performs an action for the given device. Possible actions include:
-
- power_on
- power_off
- reboot
- rescue: reboot the device into rescue OS.
- */
-public enum ActionType {

ok :D

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1112#discussion_r121201959