You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/31 00:33:18 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35013: [SPARK-37734][BUILD][SQL] Upgrade h2 from 1.4.195 to 2.0.202

dongjoon-hyun commented on a change in pull request #35013:
URL: https://github.com/apache/spark/pull/35013#discussion_r776898249



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
##########
@@ -638,7 +638,7 @@ class JDBCSuite extends QueryTest
     assert(rows(0).getAs[Array[Byte]](0).sameElements(testBytes))
     assert(rows(0).getString(1).equals("Sensitive"))
     assert(rows(0).getString(2).equals("Insensitive"))
-    assert(rows(0).getString(3).equals("Twenty-byte CHAR"))
+    assert(rows(0).getString(3).equals("Twenty-byte CHAR    "))

Review comment:
       Yes, new result is correct. It's nice to have this update.
   
   https://github.com/apache/spark/blob/4caface4b635bc339da370ac644855f47d46b01f/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala#L154




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org