You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/02 21:25:40 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7422: Add
`validate_sql_json` endpoint for checking that a given sql query is valid
for the chosen database
codecov-io commented on issue #7422: Add `validate_sql_json` endpoint for checking that a given sql query is valid for the chosen database
URL: https://github.com/apache/incubator-superset/pull/7422#issuecomment-488837921
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7422?src=pr&el=h1) Report
> Merging [#7422](https://codecov.io/gh/apache/incubator-superset/pull/7422?src=pr&el=desc) into [lyft-release-sp8](https://codecov.io/gh/apache/incubator-superset/commit/51c7f92c23e081f661de2d2ecdcd793b5785b58c?src=pr&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `88.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7422?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## lyft-release-sp8 #7422 +/- ##
====================================================
+ Coverage 65% 65.13% +0.13%
====================================================
Files 429 432 +3
Lines 21095 21221 +126
Branches 2337 2337
====================================================
+ Hits 13712 13823 +111
- Misses 7259 7274 +15
Partials 124 124
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7422?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/7422/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `93.86% <100%> (+0.07%)` | :arrow_up: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/7422/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `100% <100%> (ø)` | |
| [superset/sql\_validators/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/7422/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvX19pbml0X18ucHk=) | `83.33% <83.33%> (ø)` | |
| [superset/sql\_validators/presto\_db.py](https://codecov.io/gh/apache/incubator-superset/pull/7422/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcHJlc3RvX2RiLnB5) | `84.5% <84.5%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7422/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.95% <90.9%> (+0.41%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7422?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7422?src=pr&el=footer). Last update [51c7f92...1700eeb](https://codecov.io/gh/apache/incubator-superset/pull/7422?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org