[GitHub] [incubator-openwhisk-runtime-php] falkzoll commented on a change in pull request #55: Update to php7.1.27, 7.2.16 and 7.3.3.

[GitBox <gi...@apache.org>]

falkzoll commented on a change in pull request #55: Update to php7.1.27, 7.2.16 and 7.3.3.
URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/55#discussion_r269950105
 
 

 ##########
 File path: core/php7.1Action/CHANGELOG.md
 ##########
 @@ -19,8 +19,9 @@
 
 ## Apache 1.13.0-incubating (next release)
 Changes:
-  - Update version of PHP to 7.1.26
+  - Update version of PHP to 7.1.27
 
+## 1.12.0-incubating
 
 Review comment:
   I added the tag since I have seen this in the docker registry (e.g. https://hub.docker.com/r/openwhisk/action-php-v7.1/tags) and it was not documented in the CHANGELOG.md of the individual runtime images, yet.
   
   I looked at the history.
   The change from 1.0.3 to 1.12.0-incubating was to revert the content of copyright to the content in the template in LICENSE.txt (https://github.com/apache/incubator-openwhisk-runtime-php/commit/93c1871421fc92441cab8d4b1d23a31f18d7506e) on Aug 28, 2018. This change is not related to the generated docker images.
   Means, the images of 1.0.3 and 1.12.0-incubating are functional identical. Which I tried to visualize by not having a 'Changes' section in between the 2 versions.
   
   In case there is a more common way to show this, I can adjust it accordingly :-). 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services