You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/07/31 00:27:33 UTC
[jira] Created: (THRIFT-100) In java:beans generator, when calling
setX, if null is passed, set isset accordingly
In java:beans generator, when calling setX, if null is passed, set isset accordingly
------------------------------------------------------------------------------------
Key: THRIFT-100
URL: https://issues.apache.org/jira/browse/THRIFT-100
Project: Thrift
Issue Type: Improvement
Components: Compiler (Java)
Reporter: Bryan Duxbury
Priority: Minor
The java beans generator creates getters and setters for all fields. However, it assumes that when you call set whatever, that the value passed is a non-null value, and sets isset to true no matter what. At the very least, it should set isset based on whether the passed value is null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-100) In java:beans generator, when calling
setX, if null is passed, set isset accordingly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury resolved THRIFT-100.
----------------------------------
Resolution: Fixed
Committed by dreiss.
> In java:beans generator, when calling setX, if null is passed, set isset accordingly
> ------------------------------------------------------------------------------------
>
> Key: THRIFT-100
> URL: https://issues.apache.org/jira/browse/THRIFT-100
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-100-v2.patch, thrift-100.patch
>
>
> The java beans generator creates getters and setters for all fields. However, it assumes that when you call set whatever, that the value passed is a non-null value, and sets isset to true no matter what. At the very least, it should set isset based on whether the passed value is null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-100) In java:beans generator, when calling
setX, if null is passed, set isset accordingly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-100:
---------------------------------
Attachment: thrift-100.patch
> In java:beans generator, when calling setX, if null is passed, set isset accordingly
> ------------------------------------------------------------------------------------
>
> Key: THRIFT-100
> URL: https://issues.apache.org/jira/browse/THRIFT-100
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-100.patch
>
>
> The java beans generator creates getters and setters for all fields. However, it assumes that when you call set whatever, that the value passed is a non-null value, and sets isset to true no matter what. At the very least, it should set isset based on whether the passed value is null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-100) In java:beans generator, when calling
setX, if null is passed, set isset accordingly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-100:
------------------------------------
Assignee: Bryan Duxbury
> In java:beans generator, when calling setX, if null is passed, set isset accordingly
> ------------------------------------------------------------------------------------
>
> Key: THRIFT-100
> URL: https://issues.apache.org/jira/browse/THRIFT-100
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-100.patch
>
>
> The java beans generator creates getters and setters for all fields. However, it assumes that when you call set whatever, that the value passed is a non-null value, and sets isset to true no matter what. At the very least, it should set isset based on whether the passed value is null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-100) In java:beans generator, when
calling setX, if null is passed, set isset accordingly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633087#action_12633087 ]
Bryan Duxbury commented on THRIFT-100:
--------------------------------------
Looks like an improvement to me, nice job.
> In java:beans generator, when calling setX, if null is passed, set isset accordingly
> ------------------------------------------------------------------------------------
>
> Key: THRIFT-100
> URL: https://issues.apache.org/jira/browse/THRIFT-100
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-100-v2.patch, thrift-100.patch
>
>
> The java beans generator creates getters and setters for all fields. However, it assumes that when you call set whatever, that the value passed is a non-null value, and sets isset to true no matter what. At the very least, it should set isset based on whether the passed value is null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-100) In java:beans generator, when calling
setX, if null is passed, set isset accordingly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-100:
---------------------------------
Patch Info: [Patch Available]
> In java:beans generator, when calling setX, if null is passed, set isset accordingly
> ------------------------------------------------------------------------------------
>
> Key: THRIFT-100
> URL: https://issues.apache.org/jira/browse/THRIFT-100
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-100.patch
>
>
> The java beans generator creates getters and setters for all fields. However, it assumes that when you call set whatever, that the value passed is a non-null value, and sets isset to true no matter what. At the very least, it should set isset based on whether the passed value is null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-100) In java:beans generator, when calling
setX, if null is passed, set isset accordingly
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-100:
-------------------------------
Attachment: thrift-100-v2.patch
How about this?
> In java:beans generator, when calling setX, if null is passed, set isset accordingly
> ------------------------------------------------------------------------------------
>
> Key: THRIFT-100
> URL: https://issues.apache.org/jira/browse/THRIFT-100
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-100-v2.patch, thrift-100.patch
>
>
> The java beans generator creates getters and setters for all fields. However, it assumes that when you call set whatever, that the value passed is a non-null value, and sets isset to true no matter what. At the very least, it should set isset based on whether the passed value is null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.