[jira] [Comment Edited] (IGNITE-12904) Add method IgniteSecurity#securityContext(UUID subjId)

["Nikolay Izhikov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087815#comment-17087815 ] 

Nikolay Izhikov edited comment on IGNITE-12904 at 4/20/20, 2:54 PM:
--------------------------------------------------------------------

Hello [~garus.d.g]

I reviewed your patch and have couple of comment:

* For now, we have `IgniteSpiContext#authenticatedSubject(UUID subjId)` which is the same method as you suggested to add.
* It's not clear for me, who and when should use this new method.
* If we want to provide this method to the user we should do the following:
 ** Add `authenticatedSubject(UUID subjId)` to the PluginContext to provide this feature into plugins.
** Add `IgniteSecurity` public interface and methods `Collection<SecuritySubject> authenticatedSubjects()`, `SecuritySubject authenticatedSubject(UUID subjId)` to it to provide this feature into public API.

It seems we should discuss this improvement on the dev-list.
Does it makes sense for you?




was (Author: nizhikov):
Hello [~garus.d.g]

I reviewed your patch and have couple of comment:

1. For now, we have `IgniteSpiContext#authenticatedSubject(UUID subjId)` which is the same method as you suggested to add.
2. It's not clear for me, who and when should use this new method.
3. If we want to provide this method to the user we should do the following:
    а. Add `authenticatedSubject(UUID subjId)` to the PluginContext to provide this feature into plugins.
    b. Add `IgniteSecurity` public interface and methods `Collection<SecuritySubject> authenticatedSubjects()`, `SecuritySubject authenticatedSubject(UUID subjId)` to it to provide this feature into public API.

It seems we should discuss this improvement on the dev-list.
Does it makes sense for you?



> Add method IgniteSecurity#securityContext(UUID subjId)
> ------------------------------------------------------
>
>                 Key: IGNITE-12904
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12904
>             Project: Ignite
>          Issue Type: Improvement
>          Components: security
>            Reporter: Denis Garus
>            Assignee: Denis Garus
>            Priority: Major
>              Labels: iep-41
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We should add method IgniteSecurity#securityContext(UUID subjId) to allow users to get a security subject info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)