You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sa...@apache.org on 2014/06/30 15:43:24 UTC

svn commit: r1606734 - in /lucene/dev/trunk/solr: CHANGES.txt core/src/test/org/apache/solr/schema/PrimitiveFieldTypeTest.java

Author: sarowe
Date: Mon Jun 30 13:43:24 2014
New Revision: 1606734

URL: http://svn.apache.org/r1606734
Log:
SOLR-6211: TrieDateField doesn't default to omitNorms=true.

Modified:
    lucene/dev/trunk/solr/CHANGES.txt
    lucene/dev/trunk/solr/core/src/test/org/apache/solr/schema/PrimitiveFieldTypeTest.java

Modified: lucene/dev/trunk/solr/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/CHANGES.txt?rev=1606734&r1=1606733&r2=1606734&view=diff
==============================================================================
--- lucene/dev/trunk/solr/CHANGES.txt (original)
+++ lucene/dev/trunk/solr/CHANGES.txt Mon Jun 30 13:43:24 2014
@@ -89,6 +89,24 @@ Other Changes
 
 ==================  4.10.0 =================
 
+Versions of Major Components
+---------------------
+Apache Tika 1.5
+Carrot2 3.9.0
+Velocity 1.7 and Velocity Tools 2.0
+Apache UIMA 2.3.1
+Apache ZooKeeper 3.4.6
+
+Upgrading from Solr 4.9
+----------------------
+
+* In Solr 3.6, all primitive field types were changed to omit norms by default when the
+  schema version is 1.5 or greater (SOLR-3140), but TrieDateField's default was mistakenly
+  not changed.  As of Solr 4.10, TrieDateField omits norms by default (see SOLR-6211).
+
+Detailed Change List
+----------------------
+
 New Features
 ----------------------
 * SOLR-6196: The overseerstatus collection API instruments amILeader and ZK state update calls.
@@ -117,6 +135,8 @@ Bug Fixes
 
 * SOLR-6072: The 'deletereplica' API should remove the data and instance directory by default.
   (shalin)
+  
+* SOLR-6211: TrieDateField doesn't default to omitNorms=true. (Michael Ryan, Steve Rowe)
 
 Other Changes
 ---------------------

Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/schema/PrimitiveFieldTypeTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/schema/PrimitiveFieldTypeTest.java?rev=1606734&r1=1606733&r2=1606734&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/schema/PrimitiveFieldTypeTest.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/schema/PrimitiveFieldTypeTest.java Mon Jun 30 13:43:24 2014
@@ -63,6 +63,9 @@ public class PrimitiveFieldTypeTest exte
     TrieDateField dt;
     StrField s;
     TrieIntField ti;
+    TrieLongField tl;
+    TrieFloatField tf;
+    TrieDoubleField td;
     BoolField b;
     
     
@@ -83,6 +86,18 @@ public class PrimitiveFieldTypeTest exte
     ti.init(schema, initMap);
     assertFalse(ti.hasProperty(FieldType.OMIT_NORMS));
 
+    tl = new TrieLongField();
+    tl.init(schema, initMap);
+    assertFalse(tl.hasProperty(FieldType.OMIT_NORMS));
+
+    tf = new TrieFloatField();
+    tf.init(schema, initMap);
+    assertFalse(tf.hasProperty(FieldType.OMIT_NORMS));
+
+    td = new TrieDoubleField();
+    td.init(schema, initMap);
+    assertFalse(td.hasProperty(FieldType.OMIT_NORMS));
+
     b = new BoolField();
     b.init(schema, initMap);
     assertFalse(b.hasProperty(FieldType.OMIT_NORMS));
@@ -113,6 +128,18 @@ public class PrimitiveFieldTypeTest exte
     ti.init(schema, initMap);
     assertTrue(ti.hasProperty(FieldType.OMIT_NORMS));
 
+    tl = new TrieLongField();
+    tl.init(schema, initMap);
+    assertTrue(tl.hasProperty(FieldType.OMIT_NORMS));
+
+    tf = new TrieFloatField();
+    tf.init(schema, initMap);
+    assertTrue(tf.hasProperty(FieldType.OMIT_NORMS));
+
+    td = new TrieDoubleField();
+    td.init(schema, initMap);
+    assertTrue(td.hasProperty(FieldType.OMIT_NORMS));
+
     b = new BoolField();
     b.init(schema, initMap);
     assertTrue(b.hasProperty(FieldType.OMIT_NORMS));