You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Eric Milles (Jira)" <ji...@apache.org> on 2023/02/12 15:54:00 UTC
[jira] [Updated] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Milles updated GROOVY-10931:
---------------------------------
Description:
The new {{$getLookup()}} method was discussed somewhat in the comments of GROOVY-10273. Groovy 3 has had JEP 396 (illegal access enforcement) support backported to the invoke dynamic pathways, without {{$getLookup}}. So, I'd like to restart the discussion to find out if there are any illegal-access scenarios that Groovy 4 supports that don't have a test case in Groovy 3. And if there are no scenarios that remain, I'd like to propose the removal of {{$getLookup}} method generation.
I have disabled its generation in the Groovy 5 codebase, and there are no tests that fail. So I have good confidence that it can be removed and the security hole can be plugged.
was:
The new {{$getLookup()}} method was discussed somewhat in the comments of GROOVY-10273. Groovy 3 has had JEP 396 (illegal access enforcement) support backported to the invoke dynamic pathways, without {{$getLookup}}. So, I'd like to restart the discussion to find out if there are any scenarios that Groovy 4 supports that don't have a test case in Groovy 3. And if there are no scenarios that remain, I'd like to propose the removal of {{$getLookup}} method generation.
I have disabled its generation in the Groovy 5 codebase, and there are no tests that fail. So I have good confidence that it can be removed and the security hole can be plugged.
> Remove $getLookup method generation (Groovy 4+)
> -----------------------------------------------
>
> Key: GROOVY-10931
> URL: https://issues.apache.org/jira/browse/GROOVY-10931
> Project: Groovy
> Issue Type: Wish
> Components: class generator, Compiler
> Affects Versions: 5.0.0-alpha-1, 4.0.9
> Reporter: Eric Milles
> Assignee: Eric Milles
> Priority: Major
>
> The new {{$getLookup()}} method was discussed somewhat in the comments of GROOVY-10273. Groovy 3 has had JEP 396 (illegal access enforcement) support backported to the invoke dynamic pathways, without {{$getLookup}}. So, I'd like to restart the discussion to find out if there are any illegal-access scenarios that Groovy 4 supports that don't have a test case in Groovy 3. And if there are no scenarios that remain, I'd like to propose the removal of {{$getLookup}} method generation.
> I have disabled its generation in the Groovy 5 codebase, and there are no tests that fail. So I have good confidence that it can be removed and the security hole can be plugged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)