[GitHub] garrensmith commented on issue #933: Update for changes to _cluster_setup endpoint

[gi...@git.apache.org]

garrensmith commented on issue #933: Update for changes to _cluster_setup endpoint
URL: https://github.com/apache/couchdb-fauxton/pull/933#issuecomment-317480716
 
 
   So does that mean it's not possible to setup a cluster larger than 3 nodes?
   
   All misspelling thanks to my iPhone.
   ________________________________
   From: Joan Touzet <no...@github.com>
   Sent: Monday, July 24, 2017 6:10:28 PM
   To: apache/couchdb-fauxton
   Cc: garren smith; Review requested
   Subject: Re: [apache/couchdb-fauxton] Update for changes to _cluster_setup endpoint (#933)
   
   
   @wohali commented on this pull request.
   
   ________________________________
   
   In app/addons/setup/setup.stores.js<https://github.com/apache/couchdb-fauxton/pull/933#discussion_r129080975>:
   
   > @@ -91,6 +92,14 @@ var SetupStore = FauxtonAPI.Store.extend({
        return this._setupNode.bindAddress;
      },
   
   +  setNodeCountForSetupNode: function (options) {
   +    this._setupNode.nodeCount = Math.min(options.value, 3);
   
   
   This sets the cluster n value, so it should set n = 3.
   
   ?
   You are receiving this because your review was requested.
   Reply to this email directly, view it on GitHub<https://github.com/apache/couchdb-fauxton/pull/933#discussion_r129080975>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAK9Aurd7uMTa6RuJRNIBEM-lOLE4qpAks5sRMHzgaJpZM4OZlqR>.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services