You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2010/11/19 19:24:14 UTC
[jira] Created: (CXF-3137) Simplify http connection factory in http
transport (please review)
Simplify http connection factory in http transport (please review)
-------------------------------------------------------------------
Key: CXF-3137
URL: https://issues.apache.org/jira/browse/CXF-3137
Project: CXF
Issue Type: Improvement
Components: Transports
Affects Versions: 2.3.0
Reporter: Christian Schneider
Assignee: Christian Schneider
Fix For: 2.3.1
Attachments: cxf-rt-transports-http-3137.patch
Currently the http transport uses a quite complicated way to create http url connections. There are two factories (for http and https). One is selected and cached. Then when you change the config of the transport it is eventually replaced.
I propose to make this much simpler by having only a https url connection factory that also handles the http case. The new code has one little drawback it also eliminates the ConnectionInfo classes partly. I think that is not a big issue as I think this classes are only used for https trust decisions. It would be great though if someone could review the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-3137) Simplify http connection factory in http
transport (please review)
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated CXF-3137:
-------------------------------------
Attachment: cxf-rt-transports-http-3137.patch
> Simplify http connection factory in http transport (please review)
> -------------------------------------------------------------------
>
> Key: CXF-3137
> URL: https://issues.apache.org/jira/browse/CXF-3137
> Project: CXF
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 2.3.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 2.3.1
>
> Attachments: cxf-rt-transports-http-3137.patch
>
>
> Currently the http transport uses a quite complicated way to create http url connections. There are two factories (for http and https). One is selected and cached. Then when you change the config of the transport it is eventually replaced.
> I propose to make this much simpler by having only a https url connection factory that also handles the http case. The new code has one little drawback it also eliminates the ConnectionInfo classes partly. I think that is not a big issue as I think this classes are only used for https trust decisions. It would be great though if someone could review the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CXF-3137) Simplify http connection factory in
http transport (please review)
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider resolved CXF-3137.
--------------------------------------
Resolution: Fixed
> Simplify http connection factory in http transport (please review)
> -------------------------------------------------------------------
>
> Key: CXF-3137
> URL: https://issues.apache.org/jira/browse/CXF-3137
> Project: CXF
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 2.3.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 2.3.1
>
> Attachments: cxf-rt-transports-http-3137.patch
>
>
> Currently the http transport uses a quite complicated way to create http url connections. There are two factories (for http and https). One is selected and cached. Then when you change the config of the transport it is eventually replaced.
> I propose to make this much simpler by having only a https url connection factory that also handles the http case. The new code has one little drawback it also eliminates the ConnectionInfo classes partly. I think that is not a big issue as I think this classes are only used for https trust decisions. It would be great though if someone could review the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-3137) Simplify http connection factory in http
transport (please review)
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp updated CXF-3137:
-----------------------------
Fix Version/s: (was: 2.3.1)
2.4
> Simplify http connection factory in http transport (please review)
> -------------------------------------------------------------------
>
> Key: CXF-3137
> URL: https://issues.apache.org/jira/browse/CXF-3137
> Project: CXF
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 2.3.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 2.4
>
> Attachments: cxf-rt-transports-http-3137.patch
>
>
> Currently the http transport uses a quite complicated way to create http url connections. There are two factories (for http and https). One is selected and cached. Then when you change the config of the transport it is eventually replaced.
> I propose to make this much simpler by having only a https url connection factory that also handles the http case. The new code has one little drawback it also eliminates the ConnectionInfo classes partly. I think that is not a big issue as I think this classes are only used for https trust decisions. It would be great though if someone could review the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-3137) Simplify http connection factory in
http transport (please review)
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933927#action_12933927 ]
Daniel Kulp commented on CXF-3137:
----------------------------------
Patch looks good. It definitely simplifies things quite a bit. All the work you are doing should make it easier to get my AsyncClient version working a little easier as well as things are cleaned up and put into smaller work units and such.
At one point, I think there was an intention to have the ConnectionInfo object added to the message to allow other things besides the Trust things to use it, but looking at the code, that never happened. Thus, I'm definitely OK with what's in the patch.
> Simplify http connection factory in http transport (please review)
> -------------------------------------------------------------------
>
> Key: CXF-3137
> URL: https://issues.apache.org/jira/browse/CXF-3137
> Project: CXF
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 2.3.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 2.3.1
>
> Attachments: cxf-rt-transports-http-3137.patch
>
>
> Currently the http transport uses a quite complicated way to create http url connections. There are two factories (for http and https). One is selected and cached. Then when you change the config of the transport it is eventually replaced.
> I propose to make this much simpler by having only a https url connection factory that also handles the http case. The new code has one little drawback it also eliminates the ConnectionInfo classes partly. I think that is not a big issue as I think this classes are only used for https trust decisions. It would be great though if someone could review the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CXF-3137) Simplify http connection factory in http
transport (please review)
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider closed CXF-3137.
------------------------------------
> Simplify http connection factory in http transport (please review)
> -------------------------------------------------------------------
>
> Key: CXF-3137
> URL: https://issues.apache.org/jira/browse/CXF-3137
> Project: CXF
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 2.3.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 2.3.1
>
> Attachments: cxf-rt-transports-http-3137.patch
>
>
> Currently the http transport uses a quite complicated way to create http url connections. There are two factories (for http and https). One is selected and cached. Then when you change the config of the transport it is eventually replaced.
> I propose to make this much simpler by having only a https url connection factory that also handles the http case. The new code has one little drawback it also eliminates the ConnectionInfo classes partly. I think that is not a big issue as I think this classes are only used for https trust decisions. It would be great though if someone could review the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.