[jira] [Comment Edited] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.

["Jeff Jirsa (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528028#comment-15528028 ] 

Jeff Jirsa edited comment on CASSANDRA-12681 at 9/28/16 1:29 AM:
-----------------------------------------------------------------

Dtest merged this morning (thanks [~philipthompson]!), and they look great (no failures - http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-3.0-dtest/lastCompletedBuild/testReport/ and http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-dtest/lastCompletedBuild/testReport/ ).

Committed into 3.0.10 as {{f2c5ad743933498e60e7eef55e8daaa6ce338a03}} , trunk merge as {{d45f323eb972c6fec146e5cfa84fdc47eb8aa5eb}}

Thanks [~nachiket_patil]!



was (Author: jjirsa):
Dtest merged this morning (thanks [~philipthompson]!), and they look great (no failures).

Committed into 3.0.10 as {{f2c5ad743933498e60e7eef55e8daaa6ce338a03}} , trunk merge as {{d45f323eb972c6fec146e5cfa84fdc47eb8aa5eb}}

Thanks [~nachiket_patil]!


> Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12681
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12681
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Distributed Metadata
>            Reporter: Nachiket Patil
>            Assignee: Nachiket Patil
>            Priority: Minor
>             Fix For: 3.10, 3.0.10
>
>         Attachments: trunkpatch.diff, v3.0patch.diff
>
>
> Add some restrictions around create / alter keyspace with NetworkTopologyStrategy:
> 1. Do not accept empty replication configuration (no DC options after class). Cassandra checks that SimpleStrategy must have replication_factor option but does not check that at least one DC should be present in the options for NetworkTopologyStrategy.
> 2. Cassandra accepts any random string as DC name replication option for NetworkTopologyStrategy while creating or altering keyspaces. Add a restriction that the options specified is valid datacenter name. Using incorrect value or simple mistake in typing the DC name can cause outage in production environment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)