You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/14 21:43:58 UTC

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs

apeforest commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs 
URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r366588180
 
 

 ##########
 File path: include/mxnet/c_api.h
 ##########
 @@ -585,6 +585,8 @@ MXNET_DLL int MXNDArrayCreate(const uint32_t *shape,
 
 /*!
  * \brief create a NDArray with specified shape and data type
+ *  This api is available when MXNet is built with flag
+ *  USE_INT64_TENSOR_SIZE=0 (by default)
 
 Review comment:
   I think instead of adding the comment, we should just error out from the API when the incorrect flags are used with API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services