You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Aihua Xu <ax...@cloudera.com> on 2015/08/26 22:14:49 UTC
Review Request 37810: HIVE-10021 "Alter index rebuild" statements
submitted through HiveServer2 fail when Sentry is enabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37810/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
HIVE-10021 "Alter index rebuild" statements submitted through HiveServer2 fail when Sentry is enabled
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/Context.java ca0d487b8195da7c848a8212a5b869620ee857af
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4030075dc5393b60bff25c50a700ccffdb1720bc
ql/src/java/org/apache/hadoop/hive/ql/index/AbstractIndexHandler.java 1d27306ef1a644e4ad37a73f6f9eeed92cf79a5a
ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java e67996d3fba94e9ff33078f4bf7fd97141103138
ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java b076933b7bd6611cd4b678441cd1cc2b0e16786b
ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 1dbe230917564d5c17c198a898d4de7b52adab3b
ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java 92cae67e9111d42b36594cf44a174fb9f0812a7a
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 9f8c756bed3811f04ec1dc8625f89724faab99ff
Diff: https://reviews.apache.org/r/37810/diff/
Testing
-------
Thanks,
Aihua Xu
Re: Review Request 37810: HIVE-10021 "Alter index rebuild" statements
submitted through HiveServer2 fail when Sentry is enabled
Posted by Aihua Xu <ax...@cloudera.com>.
> On Aug. 27, 2015, 8:57 p.m., Chao Sun wrote:
> > Patch looks good. Just one question: instead of populating the user name in several places, is it possible to use the one stored in SessionState (by calling SessionState.get().getUserName() before creating the Driver)?
>
> Aihua Xu wrote:
> Didn't know there is one in SessionState. Let me take a look how those usernames are co-related.
Updated to use the userName saved in the sessionState and it seems to be the better way to save and use userName. While I do get lost to track if the userName in the session would be set properly for all the pathes.
- Aihua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37810/#review96749
-----------------------------------------------------------
On Aug. 26, 2015, 8:14 p.m., Aihua Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37810/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 8:14 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-10021 "Alter index rebuild" statements submitted through HiveServer2 fail when Sentry is enabled
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Context.java ca0d487b8195da7c848a8212a5b869620ee857af
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4030075dc5393b60bff25c50a700ccffdb1720bc
> ql/src/java/org/apache/hadoop/hive/ql/index/AbstractIndexHandler.java 1d27306ef1a644e4ad37a73f6f9eeed92cf79a5a
> ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java e67996d3fba94e9ff33078f4bf7fd97141103138
> ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java b076933b7bd6611cd4b678441cd1cc2b0e16786b
> ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 1dbe230917564d5c17c198a898d4de7b52adab3b
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java 92cae67e9111d42b36594cf44a174fb9f0812a7a
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 9f8c756bed3811f04ec1dc8625f89724faab99ff
>
> Diff: https://reviews.apache.org/r/37810/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aihua Xu
>
>
Re: Review Request 37810: HIVE-10021 "Alter index rebuild" statements
submitted through HiveServer2 fail when Sentry is enabled
Posted by Chao Sun <ch...@cloudera.com>.
> On Aug. 27, 2015, 8:57 p.m., Chao Sun wrote:
> > Patch looks good. Just one question: instead of populating the user name in several places, is it possible to use the one stored in SessionState (by calling SessionState.get().getUserName() before creating the Driver)?
>
> Aihua Xu wrote:
> Didn't know there is one in SessionState. Let me take a look how those usernames are co-related.
>
> Aihua Xu wrote:
> Updated to use the userName saved in the sessionState and it seems to be the better way to save and use userName. While I do get lost to track if the userName in the session would be set properly for all the pathes.
I think the SessionState is setup before the query is executed and should be available during the whole lifetime of it.
- Chao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37810/#review96749
-----------------------------------------------------------
On Aug. 28, 2015, 3:16 p.m., Aihua Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37810/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2015, 3:16 p.m.)
>
>
> Review request for hive and Chao Sun.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-10021 "Alter index rebuild" statements submitted through HiveServer2 fail when Sentry is enabled
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java 92cae67
>
> Diff: https://reviews.apache.org/r/37810/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aihua Xu
>
>
Re: Review Request 37810: HIVE-10021 "Alter index rebuild" statements
submitted through HiveServer2 fail when Sentry is enabled
Posted by Aihua Xu <ax...@cloudera.com>.
> On Aug. 27, 2015, 8:57 p.m., Chao Sun wrote:
> > Patch looks good. Just one question: instead of populating the user name in several places, is it possible to use the one stored in SessionState (by calling SessionState.get().getUserName() before creating the Driver)?
Didn't know there is one in SessionState. Let me take a look how those usernames are co-related.
- Aihua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37810/#review96749
-----------------------------------------------------------
On Aug. 26, 2015, 8:14 p.m., Aihua Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37810/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 8:14 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-10021 "Alter index rebuild" statements submitted through HiveServer2 fail when Sentry is enabled
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Context.java ca0d487b8195da7c848a8212a5b869620ee857af
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4030075dc5393b60bff25c50a700ccffdb1720bc
> ql/src/java/org/apache/hadoop/hive/ql/index/AbstractIndexHandler.java 1d27306ef1a644e4ad37a73f6f9eeed92cf79a5a
> ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java e67996d3fba94e9ff33078f4bf7fd97141103138
> ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java b076933b7bd6611cd4b678441cd1cc2b0e16786b
> ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 1dbe230917564d5c17c198a898d4de7b52adab3b
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java 92cae67e9111d42b36594cf44a174fb9f0812a7a
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 9f8c756bed3811f04ec1dc8625f89724faab99ff
>
> Diff: https://reviews.apache.org/r/37810/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aihua Xu
>
>
Re: Review Request 37810: HIVE-10021 "Alter index rebuild" statements
submitted through HiveServer2 fail when Sentry is enabled
Posted by Chao Sun <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37810/#review96749
-----------------------------------------------------------
Patch looks good. Just one question: instead of populating the user name in several places, is it possible to use the one stored in SessionState (by calling SessionState.get().getUserName() before creating the Driver)?
- Chao Sun
On Aug. 26, 2015, 8:14 p.m., Aihua Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37810/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 8:14 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-10021 "Alter index rebuild" statements submitted through HiveServer2 fail when Sentry is enabled
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Context.java ca0d487b8195da7c848a8212a5b869620ee857af
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4030075dc5393b60bff25c50a700ccffdb1720bc
> ql/src/java/org/apache/hadoop/hive/ql/index/AbstractIndexHandler.java 1d27306ef1a644e4ad37a73f6f9eeed92cf79a5a
> ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java e67996d3fba94e9ff33078f4bf7fd97141103138
> ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java b076933b7bd6611cd4b678441cd1cc2b0e16786b
> ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 1dbe230917564d5c17c198a898d4de7b52adab3b
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java 92cae67e9111d42b36594cf44a174fb9f0812a7a
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 9f8c756bed3811f04ec1dc8625f89724faab99ff
>
> Diff: https://reviews.apache.org/r/37810/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aihua Xu
>
>
Re: Review Request 37810: HIVE-10021 "Alter index rebuild" statements
submitted through HiveServer2 fail when Sentry is enabled
Posted by Aihua Xu <ax...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37810/
-----------------------------------------------------------
(Updated Aug. 28, 2015, 3:15 p.m.)
Review request for hive.
Repository: hive-git
Description
-------
HIVE-10021 "Alter index rebuild" statements submitted through HiveServer2 fail when Sentry is enabled
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java 92cae67
Diff: https://reviews.apache.org/r/37810/diff/
Testing
-------
Thanks,
Aihua Xu