[GitHub] [thrift] Jimexist commented on a diff in pull request #2779: java lib and build tool chain: gradle 8.0.2 and JDK 19

["Jimexist (via GitHub)" <gi...@apache.org>]

Jimexist commented on code in PR #2779:
URL: https://github.com/apache/thrift/pull/2779#discussion_r1161388525


##########
.github/workflows/build.yml:
##########
@@ -137,14 +137,14 @@ jobs:
     needs: compiler
     runs-on: ubuntu-20.04
     env:
-      GRADLE_VERSION: "7.6"
+      GRADLE_VERSION: "8.0.2"
     steps:
       - uses: actions/checkout@v3
 
       - uses: actions/setup-java@v3
         with:
           distribution: temurin
-          java-version: 17
+          java-version: 19

Review Comment:
   for maintainability i think we should stick with 11 (which is guaranteed using `-release` flag). i trust JDK's capability of down-compiling with newer Java versions.
   
   for build tool chain i think it is okay to move along with newest stable release.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org