You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/19 22:09:02 UTC
[GitHub] [airflow] eyalzek opened a new pull request #10411: Add `log_id` field to log lines on ES handler
eyalzek opened a new pull request #10411:
URL: https://github.com/apache/airflow/pull/10411
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-684858718
Thanks! What's next?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10411:
URL: https://github.com/apache/airflow/pull/10411
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-677803537
> I just realized that setting `log_id` might be a breaking change for people who manipulate log lines to add it manually
@eyalzek -> I think that's fine if you make a note about it in UPDATING.md file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-684527537
Can you please rebase @eyalzek ? then it will be included in backport packages 2nd wave
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eyalzek commented on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
eyalzek commented on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-677431206
I just realized that settings `log_id` might be a breaking change for people who manipulate log lines to add it manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-676798243
cc @andriisoldatenko @schnie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-676750556
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eyalzek commented on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
eyalzek commented on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-684533768
> Can you please rebase @eyalzek ? then it will be included in backport packages 2nd wave
rebased
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eyalzek commented on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
eyalzek commented on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-677813192
@potiuk after fighting with fluentd and airflow all day to get the webserver to display my task logs, I think it make sense to also include the `offset` field in this PR, otherwise it doesn't really solve anything. I'll put some work into it over the next few days and will try to update the documentation to reflect this as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-684858257
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eyalzek commented on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
eyalzek commented on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-680045505
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-684858718
Thanks! What's next !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-680044598
I think there is just a statc check to fix. We've just added black formatting so you need to rebase/rerun pre-commits and submit it again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-677848152
Cool. Thanks for putting so much effort into it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eyalzek edited a comment on pull request #10411: Add `log_id` field to log lines on ES handler
Posted by GitBox <gi...@apache.org>.
eyalzek edited a comment on pull request #10411:
URL: https://github.com/apache/airflow/pull/10411#issuecomment-677431206
I just realized that setting `log_id` might be a breaking change for people who manipulate log lines to add it manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org