[GitHub] [kafka] C0urante commented on a change in pull request #11196: KAFKA-13185 Clear message batch in rewind

[GitBox <gi...@apache.org>]

C0urante commented on a change in pull request #11196:
URL: https://github.com/apache/kafka/pull/11196#discussion_r828716597



##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java
##########
@@ -396,6 +396,8 @@ private void commitOffsets(long now, boolean closing) {
                     log.debug("{} Rewinding topic partition {} to offset {}", this, entry.getKey(), entry.getValue().offset());
                     consumer.seek(entry.getKey(), entry.getValue().offset());
                 }
+                // Clear messages that might have been left in messageBatch after last poll
+                messageBatch.clear();

Review comment:
       Do we need to also adjust `pausedForRedelivery` and resume the topic partitions here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org