You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by rb...@apache.org on 2017/01/05 23:46:38 UTC
hive git commit: HIVE-15542: NPE in StatsUtils::getColStatistics when
all values in DATE column are NULL (Rajesh Balamohan, reviewed by Gopal V)
Repository: hive
Updated Branches:
refs/heads/master c3a9fa170 -> 4e3a62071
HIVE-15542: NPE in StatsUtils::getColStatistics when all values in DATE column are NULL (Rajesh Balamohan, reviewed by Gopal V)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/4e3a6207
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/4e3a6207
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/4e3a6207
Branch: refs/heads/master
Commit: 4e3a62071d8a8d77892edc0ef3f282b190cd96fd
Parents: c3a9fa1
Author: Rajesh Balamohan <rb...@apache.org>
Authored: Fri Jan 6 05:16:27 2017 +0530
Committer: Rajesh Balamohan <rb...@apache.org>
Committed: Fri Jan 6 05:16:27 2017 +0530
----------------------------------------------------------------------
.../apache/hadoop/hive/ql/stats/StatsUtils.java | 8 +-
.../queries/clientpositive/analyze_tbl_date.q | 14 +++
.../clientpositive/analyze_tbl_date.q.out | 101 +++++++++++++++++++
3 files changed, 121 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/4e3a6207/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java b/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java
index d1f717b..0da7ea4 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java
@@ -756,8 +756,12 @@ public class StatsUtils {
}
} else if (colTypeLowerCase.equals(serdeConstants.DATE_TYPE_NAME)) {
cs.setAvgColLen(JavaDataModel.get().lengthOfDate());
- cs.setRange(csd.getDateStats().getLowValue().getDaysSinceEpoch(),
- csd.getDateStats().getHighValue().getDaysSinceEpoch());
+ cs.setNumNulls(csd.getDateStats().getNumNulls());
+ Long lowVal = (csd.getDateStats().getLowValue() != null) ? csd.getDateStats().getLowValue()
+ .getDaysSinceEpoch() : null;
+ Long highVal = (csd.getDateStats().getHighValue() != null) ? csd.getDateStats().getHighValue()
+ .getDaysSinceEpoch() : null;
+ cs.setRange(lowVal, highVal);
} else {
// Columns statistics for complex datatypes are not supported yet
return null;
http://git-wip-us.apache.org/repos/asf/hive/blob/4e3a6207/ql/src/test/queries/clientpositive/analyze_tbl_date.q
----------------------------------------------------------------------
diff --git a/ql/src/test/queries/clientpositive/analyze_tbl_date.q b/ql/src/test/queries/clientpositive/analyze_tbl_date.q
new file mode 100644
index 0000000..6726b83
--- /dev/null
+++ b/ql/src/test/queries/clientpositive/analyze_tbl_date.q
@@ -0,0 +1,14 @@
+set hive.fetch.task.conversion=none;
+
+create table test_table(d date);
+
+insert into test_table values(null), (null), (null);
+
+analyze table test_table compute statistics for columns;
+
+describe formatted test_table;
+
+explain select * from test_table where d is not null;
+
+select * from test_table where d is not null;
+
http://git-wip-us.apache.org/repos/asf/hive/blob/4e3a6207/ql/src/test/results/clientpositive/analyze_tbl_date.q.out
----------------------------------------------------------------------
diff --git a/ql/src/test/results/clientpositive/analyze_tbl_date.q.out b/ql/src/test/results/clientpositive/analyze_tbl_date.q.out
new file mode 100644
index 0000000..a0cdbca
--- /dev/null
+++ b/ql/src/test/results/clientpositive/analyze_tbl_date.q.out
@@ -0,0 +1,101 @@
+PREHOOK: query: create table test_table(d date)
+PREHOOK: type: CREATETABLE
+PREHOOK: Output: database:default
+PREHOOK: Output: default@test_table
+POSTHOOK: query: create table test_table(d date)
+POSTHOOK: type: CREATETABLE
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@test_table
+PREHOOK: query: insert into test_table values(null), (null), (null)
+PREHOOK: type: QUERY
+PREHOOK: Output: default@test_table
+POSTHOOK: query: insert into test_table values(null), (null), (null)
+POSTHOOK: type: QUERY
+POSTHOOK: Output: default@test_table
+POSTHOOK: Lineage: test_table.d EXPRESSION [(values__tmp__table__1)values__tmp__table__1.FieldSchema(name:tmp_values_col1, type:string, comment:), ]
+PREHOOK: query: analyze table test_table compute statistics for columns
+PREHOOK: type: QUERY
+PREHOOK: Input: default@test_table
+#### A masked pattern was here ####
+POSTHOOK: query: analyze table test_table compute statistics for columns
+POSTHOOK: type: QUERY
+POSTHOOK: Input: default@test_table
+#### A masked pattern was here ####
+PREHOOK: query: describe formatted test_table
+PREHOOK: type: DESCTABLE
+PREHOOK: Input: default@test_table
+POSTHOOK: query: describe formatted test_table
+POSTHOOK: type: DESCTABLE
+POSTHOOK: Input: default@test_table
+# col_name data_type comment
+
+d date
+
+# Detailed Table Information
+Database: default
+#### A masked pattern was here ####
+Retention: 0
+#### A masked pattern was here ####
+Table Type: MANAGED_TABLE
+Table Parameters:
+ COLUMN_STATS_ACCURATE {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"d\":\"true\"}}
+ numFiles 1
+ numRows 3
+ rawDataSize 6
+ totalSize 9
+#### A masked pattern was here ####
+
+# Storage Information
+SerDe Library: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
+InputFormat: org.apache.hadoop.mapred.TextInputFormat
+OutputFormat: org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
+Compressed: No
+Num Buckets: -1
+Bucket Columns: []
+Sort Columns: []
+Storage Desc Params:
+ serialization.format 1
+PREHOOK: query: explain select * from test_table where d is not null
+PREHOOK: type: QUERY
+POSTHOOK: query: explain select * from test_table where d is not null
+POSTHOOK: type: QUERY
+STAGE DEPENDENCIES:
+ Stage-1 is a root stage
+ Stage-0 depends on stages: Stage-1
+
+STAGE PLANS:
+ Stage: Stage-1
+ Map Reduce
+ Map Operator Tree:
+ TableScan
+ alias: test_table
+ Statistics: Num rows: 3 Data size: 6 Basic stats: COMPLETE Column stats: NONE
+ Filter Operator
+ predicate: d is not null (type: boolean)
+ Statistics: Num rows: 3 Data size: 6 Basic stats: COMPLETE Column stats: NONE
+ Select Operator
+ expressions: d (type: date)
+ outputColumnNames: _col0
+ Statistics: Num rows: 3 Data size: 6 Basic stats: COMPLETE Column stats: NONE
+ File Output Operator
+ compressed: false
+ Statistics: Num rows: 3 Data size: 6 Basic stats: COMPLETE Column stats: NONE
+ table:
+ input format: org.apache.hadoop.mapred.SequenceFileInputFormat
+ output format: org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat
+ serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
+
+ Stage: Stage-0
+ Fetch Operator
+ limit: -1
+ Processor Tree:
+ ListSink
+
+PREHOOK: query: select * from test_table where d is not null
+PREHOOK: type: QUERY
+PREHOOK: Input: default@test_table
+#### A masked pattern was here ####
+POSTHOOK: query: select * from test_table where d is not null
+POSTHOOK: type: QUERY
+POSTHOOK: Input: default@test_table
+#### A masked pattern was here ####