You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "lbownik (via GitHub)" <gi...@apache.org> on 2023/01/24 19:31:50 UTC
[GitHub] [netbeans] lbownik opened a new pull request, #5358: performance improvements - no logic changes
lbownik opened a new pull request, #5358:
URL: https://github.com/apache/netbeans/pull/5358
Replaced some StringBuffers with StringBuilders
fixed some "concatenation in append" issues
removed some unused objects
fixed one potential file descriptor leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5358: performance improvements - no logic changes
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5358:
URL: https://github.com/apache/netbeans/pull/5358#issuecomment-1404967326
Im save your time: jvm unseting sync flag for local StringBuffers and therefore no any speed changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5358: performance improvements - no logic changes
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5358:
URL: https://github.com/apache/netbeans/pull/5358#issuecomment-1405126664
One of the most mysterious tasks is to choose the right starting size for StringBuilder() )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik closed pull request #5358: performance improvements - no logic changes
Posted by "lbownik (via GitHub)" <gi...@apache.org>.
lbownik closed pull request #5358: performance improvements - no logic changes
URL: https://github.com/apache/netbeans/pull/5358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik commented on pull request #5358: performance improvements - no logic changes
Posted by "lbownik (via GitHub)" <gi...@apache.org>.
lbownik commented on PR #5358:
URL: https://github.com/apache/netbeans/pull/5358#issuecomment-1405034644
> Im save your time: jvm unseting sync flag for local StringBuffers and therefore no any speed changes
Good to know :)
Anyway the rest of the issues fixed in this PR still improve things a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik commented on pull request #5358: performance improvements - no logic changes
Posted by "lbownik (via GitHub)" <gi...@apache.org>.
lbownik commented on PR #5358:
URL: https://github.com/apache/netbeans/pull/5358#issuecomment-1407379674
@mbien with things that need to be reverted what will be left is not really worth merging, closing this PR, sorry for waisting your time
P.S. using TreeSet to sort an array is ... unexpected :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists