You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2014/06/25 14:33:18 UTC
Review Request 22954: Get sql metrics logic should be reviewed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22954/
-----------------------------------------------------------
Review request for Ambari, Mahadev Konar and Tom Beerbower.
Bugs: AMBARI-6266
https://issues.apache.org/jira/browse/AMBARI-6266
Repository: ambari
Description
-------
Get sql metrics logic should be reviewed
Diffs
-----
contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLPropertyProvider.java 49508ea
contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/SQLPropertyProviderTest.java d0298f3
Diff: https://reviews.apache.org/r/22954/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34.066s
[INFO] Finished at: Wed Jun 25 15:14:37 EEST 2014
[INFO] Final Memory: 37M/257M
[INFO] ------------------------------------------------------------------------
Thanks,
Artem Baranchuk
Re: Review Request 22954: Get sql metrics logic should be reviewed
Posted by Artem Baranchuk <ab...@hortonworks.com>.
> On June 25, 2014, 2:06 p.m., Tom Beerbower wrote:
> > Hi Artem, could you give some background on what this patch is doing? Is this a performance enhancement? Thanks.
Yes Tom, this is performance patch. We need to do getting metrics by single sql query.
According to testing it improves performance ~2 times
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22954/#review46621
-----------------------------------------------------------
On June 25, 2014, 12:33 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22954/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 12:33 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Tom Beerbower.
>
>
> Bugs: AMBARI-6266
> https://issues.apache.org/jira/browse/AMBARI-6266
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Get sql metrics logic should be reviewed
>
>
> Diffs
> -----
>
> contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLPropertyProvider.java 49508ea
> contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/SQLPropertyProviderTest.java d0298f3
>
> Diff: https://reviews.apache.org/r/22954/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34.066s
> [INFO] Finished at: Wed Jun 25 15:14:37 EEST 2014
> [INFO] Final Memory: 37M/257M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 22954: Get sql metrics logic should be reviewed
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22954/#review46621
-----------------------------------------------------------
Hi Artem, could you give some background on what this patch is doing? Is this a performance enhancement? Thanks.
- Tom Beerbower
On June 25, 2014, 12:33 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22954/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 12:33 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Tom Beerbower.
>
>
> Bugs: AMBARI-6266
> https://issues.apache.org/jira/browse/AMBARI-6266
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Get sql metrics logic should be reviewed
>
>
> Diffs
> -----
>
> contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLPropertyProvider.java 49508ea
> contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/SQLPropertyProviderTest.java d0298f3
>
> Diff: https://reviews.apache.org/r/22954/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34.066s
> [INFO] Finished at: Wed Jun 25 15:14:37 EEST 2014
> [INFO] Final Memory: 37M/257M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 22954: Get sql metrics logic should be reviewed
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22954/#review46637
-----------------------------------------------------------
contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLPropertyProvider.java
<https://reviews.apache.org/r/22954/#comment82142>
Was this logging left in on purpose or something left over from testing? If it's on purpose, is INFO the right level? Wouldn't this result in a lot of logging since this will be called frequently?
- Tom Beerbower
On June 25, 2014, 12:33 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22954/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 12:33 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Tom Beerbower.
>
>
> Bugs: AMBARI-6266
> https://issues.apache.org/jira/browse/AMBARI-6266
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Get sql metrics logic should be reviewed
>
>
> Diffs
> -----
>
> contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLPropertyProvider.java 49508ea
> contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/SQLPropertyProviderTest.java d0298f3
>
> Diff: https://reviews.apache.org/r/22954/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34.066s
> [INFO] Finished at: Wed Jun 25 15:14:37 EEST 2014
> [INFO] Final Memory: 37M/257M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 22954: Get sql metrics logic should be reviewed
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22954/#review46651
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On June 25, 2014, 4:39 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22954/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 4:39 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Tom Beerbower.
>
>
> Bugs: AMBARI-6266
> https://issues.apache.org/jira/browse/AMBARI-6266
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Get sql metrics logic should be reviewed
>
>
> Diffs
> -----
>
> contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLPropertyProvider.java 49508ea
> contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/SQLPropertyProviderTest.java d0298f3
>
> Diff: https://reviews.apache.org/r/22954/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34.066s
> [INFO] Finished at: Wed Jun 25 15:14:37 EEST 2014
> [INFO] Final Memory: 37M/257M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 22954: Get sql metrics logic should be reviewed
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22954/#review46678
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On June 25, 2014, 4:39 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22954/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 4:39 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Tom Beerbower.
>
>
> Bugs: AMBARI-6266
> https://issues.apache.org/jira/browse/AMBARI-6266
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Get sql metrics logic should be reviewed
>
>
> Diffs
> -----
>
> contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLPropertyProvider.java 49508ea
> contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/SQLPropertyProviderTest.java d0298f3
>
> Diff: https://reviews.apache.org/r/22954/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34.066s
> [INFO] Finished at: Wed Jun 25 15:14:37 EEST 2014
> [INFO] Final Memory: 37M/257M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 22954: Get sql metrics logic should be reviewed
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22954/
-----------------------------------------------------------
(Updated June 25, 2014, 4:39 p.m.)
Review request for Ambari, Mahadev Konar and Tom Beerbower.
Changes
-------
Yes, this is only for testing.. but be honest I have been considering to leave it with DEBUG level :)
But think we should remove it due to we don't need it. I have updated patch.
Thanks Tom!
Bugs: AMBARI-6266
https://issues.apache.org/jira/browse/AMBARI-6266
Repository: ambari
Description
-------
Get sql metrics logic should be reviewed
Diffs (updated)
-----
contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLPropertyProvider.java 49508ea
contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/SQLPropertyProviderTest.java d0298f3
Diff: https://reviews.apache.org/r/22954/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34.066s
[INFO] Finished at: Wed Jun 25 15:14:37 EEST 2014
[INFO] Final Memory: 37M/257M
[INFO] ------------------------------------------------------------------------
Thanks,
Artem Baranchuk