You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asyncband.apache.org by ti...@apache.org on 2026/09/04 08:38:31 UTC

(asyncband) 01/01: fix: keep release candidates off crates.io

This is an automated email from the ASF dual-hosted git repository.

tisonkun pushed a commit to branch codex/finalize-0.7.2-release-prep
in repository https://gitbox.apache.org/repos/asf/asyncband.git

commit 2fcda59bc193744fc5f161045b11a717e418ee01
Author: tison <wa...@gmail.com>
AuthorDate: Fri Sep 4 16:38:15 2026 +0800

    fix: keep release candidates off crates.io
---
 .github/workflows/release.yml | 17 +++--------------
 CHANGELOG.md                  |  6 ++++--
 RELEASE.md                    |  2 +-
 3 files changed, 8 insertions(+), 17 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index e8f0164..47a2440 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -112,7 +112,8 @@ jobs:
 
   publish:
     name: Publish to crates.io
-    if: ${{ startsWith(github.ref, 'refs/tags/') }}
+    # Only the final tag approved through the ASF release vote may publish to crates.io.
+    if: ${{ github.ref == format('refs/tags/v{0}', needs.check.outputs.version) }}
     needs: check
     runs-on: ubuntu-24.04
     timeout-minutes: 30
@@ -127,22 +128,10 @@ jobs:
           rustup toolchain install stable
           --profile minimal
           --no-self-update
-      - name: Prepare crates.io release candidate
-        if: ${{ needs.check.outputs.publish_version != needs.check.outputs.version }}
-        shell: bash
-        env:
-          PACKAGE_VERSION: ${{ needs.check.outputs.version }}
-          PUBLISH_VERSION: ${{ needs.check.outputs.publish_version }}
-        run: |
-          perl -pi -e 's/^version = "\Q$ENV{PACKAGE_VERSION}\E"$/version = "$ENV{PUBLISH_VERSION}"/' asyncband/Cargo.toml
-          grep -Fx "version = \"${PUBLISH_VERSION}\"" asyncband/Cargo.toml
-          cargo check --package asyncband
       - id: auth
         name: Authenticate with crates.io
         uses: rust-lang/crates-io-auth-action@c6f97d42243bad5fab37ca0427f495c86d5b1a18 # v1.0.5
       - name: Publish asyncband
-        run: >-
-          cargo publish --package asyncband --locked
-          ${{ needs.check.outputs.publish_version != needs.check.outputs.version && '--allow-dirty' || '' }}
+        run: cargo publish --package asyncband --locked
         env:
           CARGO_REGISTRY_TOKEN: ${{ steps.auth.outputs.token }}
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 95b8431..885bce9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,7 +10,7 @@ All notable changes to this project will be documented in this file.
 
 * Preserve applicable third-party licensing and copyright notices on derived source files, and record exact provenance mappings in `LICENSE` and source comments.
 
-## v0.7.1
+## v0.7.1 - 2026-09-04
 
 This is an interim non-ASF release. It has not been approved by the Apache Incubator PMC and is not an act of the Apache Software Foundation.
 
@@ -18,7 +18,9 @@ This is an interim non-ASF release. It has not been approved by the Apache Incub
 
 * Correct source-header treatment and make third-party derivation and test provenance records more precise in source distributions.
 
-## v0.7.0
+## v0.7.0 - 2026-09-04
+
+This non-ASF release was not approved by the Apache Incubator PMC, is not an act of the Apache Software Foundation, and has been yanked from crates.io.
 
 ### Breaking changes
 
diff --git a/RELEASE.md b/RELEASE.md
index 7abe9d1..2184c95 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -94,7 +94,7 @@ git tag --sign "${RC_TAG}" \
 git push https://github.com/apache/asyncband.git "${RC_TAG}"
 ```
 
-Wait for the `Release` GitHub Actions workflow to pass. The workflow publishes a convenience prerelease named `${VERSION}-rc.${RC}` to crates.io while the source tag and release candidate retain the stable `${VERSION}` package version. A candidate that needs a code change gets a new release pull request, merge commit, RC number, and signed tag.
+Wait for the `Release` GitHub Actions workflow to pass. The workflow validates a convenience prerelease package named `${VERSION}-rc.${RC}` with `cargo publish --dry-run` but does not publish it to crates.io. A candidate that needs a code change gets a new release pull request, merge commit, RC number, and signed tag.
 
 ## 3. Build and verify the source archive
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org