You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/02/08 10:44:27 UTC

Review Request: FLUME-1897. Thrift Sink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9381/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Added Thrift Sink. Refactored the Avro Sink - moved the core processing logic to AbstractRpcSink and made Thrift and Avro Sinks simple sub-classes.


This addresses bug FLUME-1897.
    https://issues.apache.org/jira/browse/FLUME-1897


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/sink/AbstractRpcSink.java PRE-CREATION 
  flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java d4ddcbe 
  flume-ng-core/src/main/java/org/apache/flume/sink/ThriftSink.java PRE-CREATION 
  flume-ng-core/src/test/java/org/apache/flume/sink/TestThriftSink.java PRE-CREATION 

Diff: https://reviews.apache.org/r/9381/diff/


Testing
-------

Added unit tests.


Thanks,

Hari Shreedharan

Re: Review Request: FLUME-1897. Thrift Sink

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9381/#review16444
-----------------------------------------------------------

Ship it!


Ship It!

- Brock Noland


On Feb. 8, 2013, 9:44 a.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9381/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2013, 9:44 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Added Thrift Sink. Refactored the Avro Sink - moved the core processing logic to AbstractRpcSink and made Thrift and Avro Sinks simple sub-classes.
> 
> 
> This addresses bug FLUME-1897.
>     https://issues.apache.org/jira/browse/FLUME-1897
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/sink/AbstractRpcSink.java PRE-CREATION 
>   flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java d4ddcbe 
>   flume-ng-core/src/main/java/org/apache/flume/sink/ThriftSink.java PRE-CREATION 
>   flume-ng-core/src/test/java/org/apache/flume/sink/TestThriftSink.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9381/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests.
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>