You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/27 18:09:47 UTC

[GitHub] [beam] pabloem commented on a diff in pull request #21752: Feature/beam 13852 reimplement with dynamic read

pabloem commented on code in PR #21752:
URL: https://github.com/apache/beam/pull/21752#discussion_r907663667


##########
sdks/java/io/kafka/build.gradle:
##########
@@ -135,7 +144,8 @@ kafkaVersions.each {kv ->
     include '**/KafkaIOIT.class'
 
     filter {
-      includeTestsMatching "*InBatch"
+      excludeTestsMatching "*InStreaming"
+      if (!(kv.key in sdfKafkaVersions)) excludeTestsMatching "*DynamicPartitions" //admin client create partitions does not exist in kafka 0.11.0.3 and kafka sdf does not appear to work for kafka versions <2.0.1

Review Comment:
   just for my edification - how / where / when do these tests run?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org