You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "gharris1727 (via GitHub)" <gi...@apache.org> on 2024/01/22 19:11:13 UTC

[PR] KAFKA-16087: Remove more leaky NamedTopologyIntegrationTest tests [kafka]

gharris1727 opened a new pull request, #15243:
URL: https://github.com/apache/kafka/pull/15243

   These tests leak resources intermittently, so I didn't catch them in #15185:
   ```
   shouldWaitForMissingInputTopicsToBeCreated:
   at org.apache.kafka.streams.processor.internals.namedtopology.KafkaStreamsNamedTopologyWrapper.<init>(KafkaStreamsNamedTopologyWrapper.java:84)
   at org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.setupSecondKafkaStreams(NamedTopologyIntegrationTest.java:239)
   at org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldWaitForMissingInputTopicsToBeCreated(NamedTopologyIntegrationTest.java:721)
   ```
   
   ```
   shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing:
   at org.apache.kafka.streams.processor.internals.namedtopology.KafkaStreamsNamedTopologyWrapper.<init>(KafkaStreamsNamedTopologyWrapper.java:84)
   at org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.setup(NamedTopologyIntegrationTest.java:224)
   ```
   
   ```
   shouldBackOffTaskAndEmitDataWithinSameTopology:
   at org.apache.kafka.streams.processor.internals.namedtopology.KafkaStreamsNamedTopologyWrapper.<init>(KafkaStreamsNamedTopologyWrapper.java:80)
   at org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldBackOffTaskAndEmitDataWithinSameTopology(NamedTopologyIntegrationTest.java:785)
   ```
   
   I haven't observed the other tests in this suite fail, but that doesn't mean they don't have leaks.
   The leaks do all seem to follow the same pattern: the close(Duration) calls time out, leaving behind resources. You can see these failures in #14783.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-15834: Remove more leaky NamedTopologyIntegrationTest tests [kafka]

Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 merged PR #15243:
URL: https://github.com/apache/kafka/pull/15243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-16087: Remove more leaky NamedTopologyIntegrationTest tests [kafka]

Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on PR #15243:
URL: https://github.com/apache/kafka/pull/15243#issuecomment-1904638343

   Hey @ableegoldman I missed some of the tests in this suite, so I had to open a follow-up. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-16087: Remove more leaky NamedTopologyIntegrationTest tests [kafka]

Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on PR #15243:
URL: https://github.com/apache/kafka/pull/15243#issuecomment-1927847757

   Test failures appear unrelated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org