[jira] [Commented] (HIVEMALL-234) Fix mismatched default value between EtaEstimator and UDF option description

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVEMALL-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749631#comment-16749631 ] 

ASF GitHub Bot commented on HIVEMALL-234:
-----------------------------------------

takuti commented on pull request #179: [HIVEMALL-234] Define `EtaEstimator` default values as constants
URL: https://github.com/apache/incubator-hivemall/pull/179
 
 
   ## What changes were proposed in this pull request?
   
   Fix mismatched default values declared in `getOptions()` and `EtaEstimator`.
   
   ## What type of PR is it?
   
   Improvement
   
   ## What is the Jira issue?
   
   https://issues.apache.org/jira/browse/HIVEMALL-234
   
   ## Checklist
   
   - [x] Did you apply source code formatter, i.e., `./bin/format_code.sh`, for your commit?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix mismatched default value between EtaEstimator and UDF option description
> ----------------------------------------------------------------------------
>
>                 Key: HIVEMALL-234
>                 URL: https://issues.apache.org/jira/browse/HIVEMALL-234
>             Project: Hivemall
>          Issue Type: Improvement
>            Reporter: Takuya Kitazawa
>            Assignee: Takuya Kitazawa
>            Priority: Minor
>
> UDF option description sometimes tells a lie:
>  * `train_mf_sgd` says default value of `eta0` is 0.2: [https://github.com/apache/incubator-hivemall/blob/7b61a3be8178fef40154f4009fef2989a9fd4c49/core/src/main/java/hivemall/mf/MatrixFactorizationSGDUDTF.java#L44]
>  * But `EtaEstimator` actually uses 0.1 as a default value: [https://github.com/apache/incubator-hivemall/blob/31932fd7c63f9bb21eba8959944d03f280b6deb9/core/src/main/java/hivemall/optimizer/EtaEstimator.java#L153]
> In order to avoid those mismatched cases, define EtaEstimator's default values as constants, and directly refer them from `getOptions`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)