[GitHub] [parquet-mr] gszadovszky edited a comment on pull request #858: PARQUET-1966: Fix build with JDK11 for JDK8

[GitBox <gi...@apache.org>]

gszadovszky edited a comment on pull request #858:
URL: https://github.com/apache/parquet-mr/pull/858#issuecomment-776598248


   > For the failed test "testMemoryManagerUpperLimit", I am not sure it is caused by this change, or the test itself is unstable. It seems the failure is because the pool size is larger than expected.
   > 
   > "should be within 10% of the expected value (expected = 453745044 actual = 505046624)"
   
   Yes, the test is flaky. Based on git history we've had to increase the percentage 3 times already. (I am not sure if this test make sense this way but I did not want to drop it for now.) Meanwhile, I have not seen this test fail until the transition to the github actions. I guess there are some environmental differences between the new actions and Travis. 
   
   But this change is not related to the flaky test. It is related to the issue caused by the first RC built with jdk11 and failed in a jre8 runtime. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org