[GitHub] [apisix-dashboard] membphis commented on a change in pull request #654: test: add Backend coverage

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #654:
URL: https://github.com/apache/apisix-dashboard/pull/654#discussion_r515976913



##########
File path: Makefile
##########
@@ -15,11 +15,18 @@
 # limitations under the License.
 #
 
+export GO111MODULE=on
+
 ### license-check:    Check apisix-dashboard source codes for Apache License
 .PHONY: license-check
 license-check:
 ifeq ("$(wildcard .actions/openwhisk-utilities/scancode/scanCode.py)", "")
 	git clone https://github.com/apache/openwhisk-utilities.git .actions/openwhisk-utilities
 	cp .actions/ASF* .actions/openwhisk-utilities/scancode/
 endif
-	.actions/openwhisk-utilities/scancode/scanCode.py --config .actions/ASF-Release.cfg ./
\ No newline at end of file
+	.actions/openwhisk-utilities/scancode/scanCode.py --config .actions/ASF-Release.cfg ./
+
+
+.PHONY: api-test

Review comment:
       please add a comment like this line: https://github.com/apache/apisix-dashboard/blob/90c11e50385b3b9dbde49c0b1c6e0f31c00995e0/Makefile#L20
   
   then we can get the command list: `make help`

##########
File path: .github/workflows/test-api.yml
##########
@@ -50,6 +50,7 @@ jobs:
         run: |
           bash <(curl -s https://codecov.io/bash)
 
+

Review comment:
       one blank line is enough




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org