[jira] [Comment Edited] (CB-3947) iTunes links do not open with inappbrowser

["Shazron Abdullah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13695155#comment-13695155 ] 

Shazron Abdullah edited comment on CB-3947 at 6/27/13 11:19 PM:
----------------------------------------------------------------

The UIWebView itself handles system urls and kicks it off to the system app (for example the itunes.apple.com URL and itms-apps://). Unfortunately, this leaves an empty InAppBrowser window, which is not desirable.

A proper fix is to detect these special URLs, and send them to the system browser (only when _blank is sent, if it is, change to _system). Pseudocode:
{code}
if (isSystemUrl(url)) {
   openInSystemBrowser(url);
}
{code}

This needs to be handled in the WebViewDelegate::shouldStartLoadRequest as well, to handle links inside of pages opened in the InAppBrowser.
                
      was (Author: shazron):
    The UIWebView itself handles system urls and kicks it off to the system app (for example the itunes.apple.com URL and itms-apps://). Unfortunately, this leaves an empty InAppBrowser window, which is not desirable.

A proper fix is to detect these special URLs, and send them to the system browser. Pseudocode:
{code}
if (isSystemUrl(url)) {
   openInSystemBrowser(url);
}
{code}

This needs to be handled in the WebViewDelegate::shouldStartLoadRequest as well, to handle links inside of pages opened in the InAppBrowser.
                  
> iTunes links do not open with inappbrowser
> ------------------------------------------
>
>                 Key: CB-3947
>                 URL: https://issues.apache.org/jira/browse/CB-3947
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS, Plugin InAppBrowser
>    Affects Versions: 2.8.0
>            Reporter: Stuart Batley
>            Assignee: Shazron Abdullah
>             Fix For: 3.0.0
>
>
> I've got inappbrowser working in my Cordova 2.8 app except that links to iTunes, like this:
> <p><a href="#" onclick="window.open('https://www.itunes.apple.com/us/app/apppname', '_blank', 'location=yes,enableViewPortScale=yes');">open</a></p>
> do not open - all other URL's open fine.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira